Performance: Avoid heap allocations when converting between int & Guid - #23389
Conversation
|
Hi there @Henr1k80, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
AndyButland
left a comment
There was a problem hiding this comment.
Thanks @Henr1k80 - all looks good. I'll merge this in and also cherry pick to v17/dev so we have it for the current LTS too.
#23389) * Avoid heap allocations when converting between int & Guid * Create better spread of test cases. * Comment the performance optimisations. --------- Co-authored-by: Andy Butland <abutland73@gmail.com>
Prerequisites