Skip to content

Dependencies: Update MailKit dependency and resolve nullability breaking changes (for Umbraco 13) - #23306

Merged
AndyButland merged 3 commits into
release/13.16.0from
v13/task/update-mailkit-dependency
Jul 8, 2026
Merged

AndyButland merged 3 commits into
release/13.16.0from
v13/task/update-mailkit-dependency

Addressed further code review feedback.

9a3fa5f
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Code Health Review (release/13.16.0) failed Jul 7, 2026 in 38s

CodeScene PR Check

Quality Gate Failed

Gates Failed
Enforce advisory code health rules (1 file with Complex Method)

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Reason for failure
Enforce advisory code health rules Violations Code Health Impact
EmailSender.cs 1 advisory rule 9.36 → 9.32 Suppress

Quality Gate Profile: Clean Code Collective
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method EmailSender.cs: SendAsyncInternal

Annotations

Check warning on line 169 in src/Umbraco.Infrastructure/Mail/EmailSender.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Code Health Review (release/13.16.0)

❌ Getting worse: Complex Method

SendAsyncInternal increases in cyclomatic complexity from 16 to 18, threshold = 9

This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid
adding more conditionals and code to it without refactoring.