Integration Tests: Adjusting Status Codes for Failing Tests

[NillasKA]

Description

This one kind of annoyed me when running tests on a different branch, and seeing these fail i had to fix them.

So this issue baffled me, because it seems the changes that caused this was introduced in my own PR #22985, that added RedirectUrlOperationStatus to the deletion of redirects. This apparently messed up some of the tests. On my PR all tests passed, so that confused me a good amount, i still do not understand why or how, but regardless i see why they are failing now.

So the issue here seems to stem from the fact that the DeleteByKeyRedirectUrlManagementControllerTests was used as part of the auth test suite to test permissions etc. The MethodSelector in these tests used to call a method that would just be void so not return anything and therefore status code OK was fine to test against, the caller had permission to call the method, no need to worry.

Now with the RedirectUrlOperationStatus these tests return NotFound, so the caller still has permission to call it, but the tests expect OK rather than NotFound. This PR adjusts the expected outcome of the method called.

[claude]

Claude finished @NillasKA's task in 1m 36s —— View job

---

PR Review

• Gather context and understand the PR
• Read changed file
• Review the changes
• Post findings and verdict

---

PR Review

Target: origin/main · Based on commit: 07a8f93d · Classified as: Test-only

Corrects three expected HTTP status codes in the redirect URL deletion auth tests from OK (200) to NotFound (404), reflecting the actual response now that the controller maps RedirectUrlOperationStatus.NotFound when the target key doesn't exist.

---

No critical, important, or suggestion-level findings.

The fix is correct and well-reasoned. Auth tests deliberately call the endpoint with a random Guid.NewGuid() that will never exist in the database — so authorized users (Admin, Editor, Writer) correctly receive 404 NotFound rather than 200 OK, while unauthorized roles still receive 403 Forbidden or 401 Unauthorized as before. The RedirectUrlManagementControllerBase confirms NotFound → 404 in its status map.

---

Approved

This looks good to be merged as-is. Thanks for tracking down the root cause and for the clear explanation in the PR description!

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[AndyButland]

Thanks @NillasKA - looks good. I wondered whether we should do some data setup so we could continue to get an OK response, but then I considered that NotFound carries out the authorisation check just as well (and that's what these controller tests are about).