-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Media Picker: Show ancestor breadcrumb path in search results table view (closes #23101) #23116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| export * from './media-picker-folder-path.element.js'; | ||
| export * from './media-picker-table-column-name.element.js'; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| import { css, customElement, html, nothing, property } from '@umbraco-cms/backoffice/external/lit'; | ||
| import { UmbLitElement } from '@umbraco-cms/backoffice/lit-element'; | ||
| import { UmbTextStyles } from '@umbraco-cms/backoffice/style'; | ||
| import type { UmbTableColumn, UmbTableColumnLayoutElement, UmbTableItem } from '@umbraco-cms/backoffice/components'; | ||
|
|
||
| export interface UmbMediaPickerTableColumnNameValue { | ||
| name: string; | ||
| ancestorPath?: string; | ||
| /** When set, the name renders as a button that invokes this on click (e.g. to open a folder). */ | ||
| navigate?: () => void; | ||
| } | ||
|
|
||
| @customElement('umb-media-picker-table-column-name') | ||
| export class UmbMediaPickerTableColumnNameElement extends UmbLitElement implements UmbTableColumnLayoutElement { | ||
| column!: UmbTableColumn; | ||
| item!: UmbTableItem; | ||
|
|
||
| @property({ attribute: false }) | ||
| value!: UmbMediaPickerTableColumnNameValue; | ||
|
|
||
| #onClick(event: Event) { | ||
| event.stopPropagation(); | ||
| this.value?.navigate?.(); | ||
| } | ||
|
|
||
| override render() { | ||
| if (!this.value) return nothing; | ||
| return html` | ||
| ${this.value.navigate | ||
| ? html`<uui-button look="default" compact label=${this.value.name} @click=${this.#onClick} | ||
| >${this.value.name}</uui-button | ||
| >` | ||
| : html`<span class="name">${this.value.name}</span>`} | ||
| ${this.value.ancestorPath | ||
| ? html`<span class="ancestor-path">${this.value.ancestorPath}</span>` | ||
| : nothing} | ||
| `; | ||
| } | ||
|
|
||
| static override styles = [ | ||
|
Check warning on line 40 in src/Umbraco.Web.UI.Client/src/packages/media/media/modals/media-picker/components/media-picker-table-column-name.element.ts
|
||
| UmbTextStyles, | ||
| css` | ||
| :host { | ||
| display: block; | ||
| } | ||
|
|
||
| uui-button { | ||
| --uui-button-padding-left-factor: 0; | ||
| text-align: left; | ||
| margin-bottom: -9px; | ||
| } | ||
|
|
||
| .name { | ||
| display: block; | ||
| overflow: hidden; | ||
| text-overflow: ellipsis; | ||
| white-space: nowrap; | ||
| } | ||
|
|
||
| .ancestor-path { | ||
| display: block; | ||
| font-size: 0.8em; | ||
| opacity: 0.6; | ||
| overflow: hidden; | ||
| text-overflow: ellipsis; | ||
| white-space: nowrap; | ||
| /* Truncate from the start so the deepest (most disambiguating) ancestor stays visible. */ | ||
| direction: rtl; | ||
| text-align: left; | ||
| } | ||
| `, | ||
| ]; | ||
| } | ||
|
|
||
| export default UmbMediaPickerTableColumnNameElement; | ||
|
|
||
| declare global { | ||
| interface HTMLElementTagNameMap { | ||
| 'umb-media-picker-table-column-name': UmbMediaPickerTableColumnNameElement; | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| import { UmbMediaPickerTableColumnNameElement } from './media-picker-table-column-name.element.js'; | ||
| import { expect, fixture, html } from '@open-wc/testing'; | ||
| import { type UmbTestRunnerWindow, defaultA11yConfig } from '@umbraco-cms/internal/test-utils'; | ||
|
|
||
| describe('UmbMediaPickerTableColumnNameElement', () => { | ||
| let element: UmbMediaPickerTableColumnNameElement; | ||
|
|
||
| beforeEach(async () => { | ||
| element = await fixture(html`<umb-media-picker-table-column-name></umb-media-picker-table-column-name>`); | ||
| }); | ||
|
|
||
| it('is defined with its own instance', () => { | ||
| expect(element).to.be.instanceOf(UmbMediaPickerTableColumnNameElement); | ||
| }); | ||
|
|
||
| it('renders the name', async () => { | ||
| element.value = { name: 'My image' }; | ||
| await element.updateComplete; | ||
| expect(element.shadowRoot?.textContent).to.contain('My image'); | ||
| }); | ||
|
|
||
| it('renders the ancestor path when provided', async () => { | ||
| element.value = { name: 'My image', ancestorPath: 'Media / Holiday' }; | ||
| await element.updateComplete; | ||
| const path = element.shadowRoot?.querySelector('.ancestor-path'); | ||
| expect(path).to.exist; | ||
| expect(path?.textContent).to.contain('Media / Holiday'); | ||
| }); | ||
|
|
||
| it('does not render an ancestor path when not provided', async () => { | ||
|
Check failure on line 30 in src/Umbraco.Web.UI.Client/src/packages/media/media/modals/media-picker/components/media-picker-table-column-name.test.ts
|
||
| element.value = { name: 'My image' }; | ||
| await element.updateComplete; | ||
| expect(element.shadowRoot?.querySelector('.ancestor-path')).to.not.exist; | ||
| }); | ||
|
|
||
| it('renders the name as a plain span when not navigable', async () => { | ||
|
Check failure on line 36 in src/Umbraco.Web.UI.Client/src/packages/media/media/modals/media-picker/components/media-picker-table-column-name.test.ts
|
||
| element.value = { name: 'My image' }; | ||
| await element.updateComplete; | ||
| expect(element.shadowRoot?.querySelector('uui-button')).to.not.exist; | ||
| expect(element.shadowRoot?.querySelector('span.name')).to.exist; | ||
| }); | ||
|
|
||
| it('renders the name as a button and invokes navigate on click', async () => { | ||
|
Check failure on line 43 in src/Umbraco.Web.UI.Client/src/packages/media/media/modals/media-picker/components/media-picker-table-column-name.test.ts
|
||
| let navigated = false; | ||
| element.value = { name: 'A folder', navigate: () => (navigated = true) }; | ||
| await element.updateComplete; | ||
|
|
||
| const button = element.shadowRoot?.querySelector('uui-button'); | ||
| expect(button).to.exist; | ||
|
|
||
| button!.dispatchEvent(new MouseEvent('click', { bubbles: true, composed: true })); | ||
| expect(navigated).to.be.true; | ||
| }); | ||
|
|
||
| it('stops the click from bubbling so it does not trigger row selection', async () => { | ||
|
Check failure on line 55 in src/Umbraco.Web.UI.Client/src/packages/media/media/modals/media-picker/components/media-picker-table-column-name.test.ts
|
||
| element.value = { name: 'A folder', navigate: () => {} }; | ||
| await element.updateComplete; | ||
|
|
||
| const button = element.shadowRoot?.querySelector('uui-button'); | ||
|
|
||
| let bubbledToHost = false; | ||
| element.addEventListener('click', () => (bubbledToHost = true)); | ||
| button!.dispatchEvent(new MouseEvent('click', { bubbles: true, composed: true })); | ||
|
|
||
| expect(bubbledToHost).to.be.false; | ||
| }); | ||
|
|
||
| if ((window as UmbTestRunnerWindow).__UMBRACO_TEST_RUN_A11Y_TEST) { | ||
| it('passes the a11y audit', async () => { | ||
| element.value = { name: 'My image', ancestorPath: 'Media / Holiday' }; | ||
| await element.updateComplete; | ||
| await expect(element).shadowDom.to.be.accessible(defaultA11yConfig); | ||
| }); | ||
| } | ||
| }); | ||
Uh oh!
There was an error while loading. Please reload this page.