Localisation: Translate the "Library" section header into other languages#23043
Conversation
|
Hi there @erikjanwestendorp, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds missing locale strings for a new/updated “Library” section label in Dutch and Spanish language bundles.
Changes:
- Added
sections.librarytranslation innl.ts - Added
sections.librarytranslation ines.ts
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Umbraco.Web.UI.Client/src/assets/lang/nl.ts | Adds Dutch translation for the new sections.library key |
| src/Umbraco.Web.UI.Client/src/assets/lang/es.ts | Adds Spanish translation for the new sections.library key |
|
Responding more fully to one of the automated comments - we don't require all translations for all languages, but as this is a pretty important one - a section header - I think we should do so in the case. It would be a bit odd to ship with all section headers translated apart from this one in some languages. I've leaned on AI to do this and have spot checked some. Also taken the opportunity to clean-up some of the keys that are no longer used in the backoffice (and don't exist in the |
There was a problem hiding this comment.
Thanks for this @erikjanwestendorp - good catch, and something we should fix up. As you'll see I've piggy-backed on this to address for the other languages too. Once merged I'll cherry-pick this in so we have it for 18.0.
Have confirmed in local testing that the translated section headers are coming through.
…ages (#23043) * Translate library to Dutch and Spanish * Add translations for other cultures. --------- Co-authored-by: Andy Butland <abutland73@gmail.com>
|
Cherry-picked to |
Added Dutch and Spanish translations for the Library section to improve localization coverage and consistency in the backoffice.