Skip to content

Localisation: Translate the "Library" section header into other languages#23043

Merged
AndyButland merged 2 commits into
umbraco:mainfrom
erikjanwestendorp:feat/translate-library-section
Jun 3, 2026
Merged

Localisation: Translate the "Library" section header into other languages#23043
AndyButland merged 2 commits into
umbraco:mainfrom
erikjanwestendorp:feat/translate-library-section

Conversation

@erikjanwestendorp

Copy link
Copy Markdown
Contributor

Added Dutch and Spanish translations for the Library section to improve localization coverage and consistency in the backoffice.

Copilot AI review requested due to automatic review settings June 2, 2026 11:10
@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown

Hi there @erikjanwestendorp, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds missing locale strings for a new/updated “Library” section label in Dutch and Spanish language bundles.

Changes:

  • Added sections.library translation in nl.ts
  • Added sections.library translation in es.ts

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/Umbraco.Web.UI.Client/src/assets/lang/nl.ts Adds Dutch translation for the new sections.library key
src/Umbraco.Web.UI.Client/src/assets/lang/es.ts Adds Spanish translation for the new sections.library key

Comment thread src/Umbraco.Web.UI.Client/src/assets/lang/es.ts Outdated
Comment thread src/Umbraco.Web.UI.Client/src/assets/lang/nl.ts Outdated
@AndyButland AndyButland self-requested a review June 3, 2026 05:45
@AndyButland

AndyButland commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Responding more fully to one of the automated comments - we don't require all translations for all languages, but as this is a pretty important one - a section header - I think we should do so in the case. It would be a bit odd to ship with all section headers translated apart from this one in some languages.

I've leaned on AI to do this and have spot checked some. Also taken the opportunity to clean-up some of the keys that are no longer used in the backoffice (and don't exist in the en.ts file).

@AndyButland AndyButland changed the title Translate library to Dutch and Spanish Localisation: Translate the "Library" section header into other languages Jun 3, 2026

@AndyButland AndyButland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @erikjanwestendorp - good catch, and something we should fix up. As you'll see I've piggy-backed on this to address for the other languages too. Once merged I'll cherry-pick this in so we have it for 18.0.

Have confirmed in local testing that the translated section headers are coming through.

@AndyButland AndyButland enabled auto-merge (squash) June 3, 2026 06:21
@AndyButland AndyButland merged commit 230b5db into umbraco:main Jun 3, 2026
34 of 35 checks passed
@erikjanwestendorp erikjanwestendorp deleted the feat/translate-library-section branch June 3, 2026 07:35
AndyButland added a commit that referenced this pull request Jun 3, 2026
…ages (#23043)

* Translate library to Dutch and Spanish

* Add translations for other cultures.

---------

Co-authored-by: Andy Butland <abutland73@gmail.com>
@AndyButland

AndyButland commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Cherry-picked to release/18.0 in cd23fc7, so will be part of 18.0.0-rc2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants