Skip to content

Property editors: Add configuration and validation of allowed types for element picker, document picker, media picker - #23026

Merged
AndyButland merged 31 commits into
mainfrom
v18/feature/element-picker-configuration-allowed-types
Jun 13, 2026
Merged

Property editors: Add configuration and validation of allowed types for element picker, document picker, media picker#23026
AndyButland merged 31 commits into
mainfrom
v18/feature/element-picker-configuration-allowed-types

Reuse shared DocumentTypePicker for picker allowed-types config.

02eedd8
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Jun 13, 2026 in 2m 1s

Quality Gate passed

Issues
18 New issues
0 Accepted issues

Measures
0 Security Hotspots
77.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 18 in src/Umbraco.Core/PropertyEditors/Validation/ITypedJsonValidator.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Missing XML comment for publicly visible type or member 'ITypedJsonValidator<TValue, TConfiguration>.Validate(TValue?, TConfiguration?, string?, PropertyValidationContext)' 

See more on https://sonarcloud.io/project/issues?id=umbraco_Umbraco-CMS&issues=AZ7A9Iy4lFS2SonGOAE6&open=AZ7A9Iy4lFS2SonGOAE6&pullRequest=23026

Check warning on line 17 in src/Umbraco.Core/PropertyEditors/Validation/ITypedJsonValidator.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this 'TODO' comment. 

See more on https://sonarcloud.io/project/issues?id=umbraco_Umbraco-CMS&issues=AZ7A9Iy4lFS2SonGOAE5&open=AZ7A9Iy4lFS2SonGOAE5&pullRequest=23026

Check warning on line 12 in src/Umbraco.Core/PropertyEditors/Validation/ITypedJsonValidator.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not forget to remove this deprecated code someday. 

See more on https://sonarcloud.io/project/issues?id=umbraco_Umbraco-CMS&issues=AZ6xRMmaw99KUS_gu39h&open=AZ6xRMmaw99KUS_gu39h&pullRequest=23026

Check warning on line 38 in src/Umbraco.Core/PropertyEditors/Validation/TypedJsonValidatorRunner.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not forget to remove this deprecated code someday. 

See more on https://sonarcloud.io/project/issues?id=umbraco_Umbraco-CMS&issues=AZ6xRMmJw99KUS_gu39g&open=AZ6xRMmJw99KUS_gu39g&pullRequest=23026

Check warning on line 224 in src/Umbraco.Core/PropertyEditors/ElementPickerPropertyEditor.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Loops should be simplified using the "Where" LINQ method 

See more on https://sonarcloud.io/project/issues?id=umbraco_Umbraco-CMS&issues=AZ6qt9p7IJMnO2KV1mku&open=AZ6qt9p7IJMnO2KV1mku&pullRequest=23026

Check warning on line 4 in src/Umbraco.Web.UI.Client/src/packages/elements/picker-data-source/element-tree.picker-data-source.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'../tree/types.js' imported multiple times. 

See more on https://sonarcloud.io/project/issues?id=umbraco_Umbraco-CMS&issues=AZ6qt9oXIJMnO2KV1mkq&open=AZ6qt9oXIJMnO2KV1mkq&pullRequest=23026

Check warning on line 133 in src/Umbraco.Core/PropertyEditors/ElementPickerPropertyEditor.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of using this literal 'validation' 4 times. 

See more on https://sonarcloud.io/project/issues?id=umbraco_Umbraco-CMS&issues=AZ6qt9p7IJMnO2KV1mks&open=AZ6qt9p7IJMnO2KV1mks&pullRequest=23026

Check failure on line 100 in src/Umbraco.Web.UI.Client/src/packages/documents/documents/search/document-search.server.data-source.test.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=umbraco_Umbraco-CMS&issues=AZ6xRMjcw99KUS_gu39f&open=AZ6xRMjcw99KUS_gu39f&pullRequest=23026

Check warning on line 5 in src/Umbraco.Web.UI.Client/src/packages/elements/picker-data-source/element-tree.picker-data-source.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'../tree/types.js' imported multiple times. 

See more on https://sonarcloud.io/project/issues?id=umbraco_Umbraco-CMS&issues=AZ6qt9oXIJMnO2KV1mkr&open=AZ6qt9oXIJMnO2KV1mkr&pullRequest=23026

Check warning on line 150 in tests/Umbraco.Tests.Integration/Umbraco.Core/Cache/RuntimeCacheTests.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer 'static readonly' fields over constant array arguments if the called method is called repeatedly and is not mutating the passed array 

See more on https://sonarcloud.io/project/issues?id=umbraco_Umbraco-CMS&issues=AZ6xRMsSw99KUS_gu39k&open=AZ6xRMsSw99KUS_gu39k&pullRequest=23026

Check failure on line 98 in src/Umbraco.Web.UI.Client/src/packages/media/media/search/media-search.server.data-source.test.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=umbraco_Umbraco-CMS&issues=AZ6xRMgmw99KUS_gu39e&open=AZ6xRMgmw99KUS_gu39e&pullRequest=23026

Check warning on line 18 in src/Umbraco.Core/PropertyEditors/Validation/ITypedJsonValidator.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Elements should be documented 

See more on https://sonarcloud.io/project/issues?id=umbraco_Umbraco-CMS&issues=AZ7A9Iy4lFS2SonGOAE7&open=AZ7A9Iy4lFS2SonGOAE7&pullRequest=23026

Check warning on line 194 in src/Umbraco.Core/PropertyEditors/ContentPickerPropertyEditor.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unnecessary Boolean literal(s). 

See more on https://sonarcloud.io/project/issues?id=umbraco_Umbraco-CMS&issues=AZ6qt9qJIJMnO2KV1mk0&open=AZ6qt9qJIJMnO2KV1mk0&pullRequest=23026

Check warning on line 43 in tests/Umbraco.Tests.UnitTests/Umbraco.Core/Cache/ObjectAppCacheTests.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not use 'Thread.Sleep()' in a test. 

See more on https://sonarcloud.io/project/issues?id=umbraco_Umbraco-CMS&issues=AZ6xRMrhw99KUS_gu39i&open=AZ6xRMrhw99KUS_gu39i&pullRequest=23026

Check warning on line 164 in tests/Umbraco.Tests.Integration/Umbraco.Core/Cache/RuntimeCacheTests.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer 'static readonly' fields over constant array arguments if the called method is called repeatedly and is not mutating the passed array 

See more on https://sonarcloud.io/project/issues?id=umbraco_Umbraco-CMS&issues=AZ6xRMsSw99KUS_gu39l&open=AZ6xRMsSw99KUS_gu39l&pullRequest=23026

Check warning on line 226 in src/Umbraco.Core/PropertyEditors/ElementPickerPropertyEditor.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unnecessary Boolean literal(s). 

See more on https://sonarcloud.io/project/issues?id=umbraco_Umbraco-CMS&issues=AZ6qt9p7IJMnO2KV1mkt&open=AZ6qt9p7IJMnO2KV1mkt&pullRequest=23026

Check warning on line 49 in tests/Umbraco.Tests.UnitTests/Umbraco.Core/Cache/ObjectAppCacheTests.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer 'static readonly' fields over constant array arguments if the called method is called repeatedly and is not mutating the passed array 

See more on https://sonarcloud.io/project/issues?id=umbraco_Umbraco-CMS&issues=AZ6xRMrhw99KUS_gu39j&open=AZ6xRMrhw99KUS_gu39j&pullRequest=23026

Check warning on line 168 in src/Umbraco.Core/PropertyEditors/ContentPickerPropertyEditor.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unnecessary Boolean literal(s). 

See more on https://sonarcloud.io/project/issues?id=umbraco_Umbraco-CMS&issues=AZ7A9I0zlFS2SonGOAE8&open=AZ7A9I0zlFS2SonGOAE8&pullRequest=23026
View more details on SonarQubeCloud