Skip to content

Element Picker: fixes "Not Found" name on removal prompt#22922

Merged
iOvergaard merged 4 commits into
release/18.0from
v18/hotfix/element-picker-removal-item-name
May 21, 2026
Merged

Element Picker: fixes "Not Found" name on removal prompt#22922
iOvergaard merged 4 commits into
release/18.0from
v18/hotfix/element-picker-removal-item-name

Conversation

@leekelleher

Copy link
Copy Markdown
Member

Description

When deleting an item from the Element Picker, the removal confirmation message would have the name "Not Found". This was due to a missing feature in the Entity Data Picker, which has since been fixed in PR #22915... and this PR patches the Element Picker (data source) code.

image

This follows PR #22915, which fixes the Entity Data Picker's
removal confirmation message with the entity's name.
Copilot AI review requested due to automatic review settings May 21, 2026 08:44
@claude

claude Bot commented May 21, 2026

Copy link
Copy Markdown

Claude finished @leekelleher's task in 1m 35s —— View job


PR Review

Target: origin/release/18.0 · Based on commit: 6a416659e201eb1b24f6a5a29c0e00176a007556
· Skipped: 0 noise files out of 1 total

Adds createItemDataResolver to UmbElementTreePickerDataSource so the entity data picker can resolve a display name for element items when building the removal confirmation message — fixing the "Not Found" label on deletion.

  • Other changes: Deletion confirmation dialogs for element picker items will now show the correct item name instead of "Not Found".

No Critical, Important, or Suggestion findings. The implementation is minimal and correct:

  • The createItemDataResolver property arrow function follows the exact same pattern as treePickableFilter in the same file and matches how the optional UmbPickerDataSource.createItemDataResolver factory is defined in types.ts.
  • UmbElementItemDataResolver is the right resolver for this data source — it handles variant-aware name resolution for element items.
  • Reordering type imports to group with other import type statements is a clean housekeeping change.

Approved

This looks good to be merged as-is, but please do a manual sanity check and testing before merging.


@leekelleher leekelleher changed the title Element Tree Picker Data Source: adds item data resolver Element Picker: fixes "Not Found" name on removal prompt May 21, 2026
@claude claude Bot added the category/ux User experience label May 21, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Elements “tree picker” data source to provide an item data resolver so that picked element items can resolve their display name (and related metadata) correctly in UI flows like the remove-confirmation dialog, aligning the Element Picker behavior with the resolver-based fix introduced for the Entity Data Picker.

Changes:

  • Adds createItemDataResolver to UmbElementTreePickerDataSource.
  • Uses UmbElementItemDataResolver to resolve element item display data via the consuming host context.

@iOvergaard iOvergaard enabled auto-merge (squash) May 21, 2026 09:00
@iOvergaard iOvergaard merged commit 831b1ac into release/18.0 May 21, 2026
25 checks passed
@iOvergaard iOvergaard deleted the v18/hotfix/element-picker-removal-item-name branch May 21, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants