E2E: QA Added acceptance tests for user management from user group

[nhudinh0309]

This PR adds acceptance test for user management from user group feature implemented in this PR: #22215

[claude]

Claude finished @nhudinh0309's task in 2m 26s —— View job

---

PR Review

Target: origin/main · Based on commit: 61dfe4dd · Classified as: Test-only

Adds 10 E2E acceptance tests covering user management from the user group workspace (view, add single/multiple, remove, persistence) along with 5 new UI helper methods in UserGroupUiHelper and a package.json script change.

---

Important

• package.json:27: The smokeTest script was narrowed from --grep "@smoke" (runs ALL @smoke-tagged tests across DefaultConfig) to DefaultConfig/Users/ManageUsersFromGroup (runs only this one file). There are dozens of other spec files with @smoke tags (DocumentType, MediaType, Templates, Scripts, etc.) that would be silently dropped from the smoke run. This appears unintentional — it should be reverted to the original grep, and if a targeted script for this file is needed, a separate entry (e.g. "testManageUsersFromGroup") should be added instead. Fix this →

---

Suggestions

• ManageUsersFromGroup.spec.ts:65,88,113,135,155-158,178,181,198,225: waitForTimeout(ConstantHelper.wait.medium) is used after picker confirmation and after remove confirmation throughout the tests. While this pattern exists in the codebase, waiting for a specific API response (similar to clickSaveButtonAndWaitForUserGroupToBeCreated) would be more reliable. Consider intercepting the user-update API call instead of relying on a 1 s fixed delay — the existing waitForResponseAfterExecutingPromise helper could be reused.

• ManageUsersFromGroup.spec.ts:37-38: The 'can view existing users in a user group' test asserts both users are visible but doesn't verify the count. A third unexpected user in the group would not be caught. Adding expect(await umbracoUi.userGroup.getUsersInGroupCount()).toBe(2) would tighten the assertion.

• ManageUsersFromGroup.spec.ts:56: writersUserGroupName = 'Writers' is declared at module scope and used as a seed-data anchor across 7 tests. This is a common pattern in the acceptance suite, but it does make the tests load-bearing on that seed group existing. A brief inline comment explaining the dependency on seed data (// seed data – "Writers" group is always present) might help future readers.

---

Approved with Suggestions for improvement

Good to go, but please address the smokeTest script regression — it silently drops all other smoke tests from the smoke run. The test logic itself is well-structured with clear AAA sections, good edge case coverage, and appropriate @smoke/@release tagging.

[andr317c]

Had a few comments

[andr317c]

Had some comments

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud