Content Workspace: Load Data-Types based on Loaded Content Types

[nielslyngsoe]

Ensures only the latest Data-Type request is used for Data-Type observation.
As well optimizes the load process, to first load Data-Types when all Content-Types(Compositions) are loaded.

Fixes #22877

[claude]

Claude encountered an error after 0s —— View job

---

I'll analyze this and get back to you.

[Copilot]

Pull request overview

This PR aims to address a race condition behind the “saveAndPublish spinner loop” by changing how data-type details are loaded/observed: it defers bulk data-type loading until all composed content-types are loaded, and tries to ensure only the latest data-type request drives observation.

Changes:

• Adjust content-type “loaded” detection to avoid triggering downstream work until content types/compositions are fully present.
• Rework data-type-unique derivation and add a guard intended to ignore stale in-flight bulk requests when updating observed data-type details.
• Export withLatestFrom via the backoffice RxJS re-export barrel.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
src/Umbraco.Web.UI.Client/src/packages/content/content-type/structure/content-type-structure-manager.class.ts	Reworks when/how data-type uniques are emitted and adds bulk-load + stale-request guarding for data-type detail observation.
src/Umbraco.Web.UI.Client/src/external/rxjs/index.ts	Re-exports withLatestFrom from RxJS for internal consumption.

Comments suppressed due to low confidence (1)

src/Umbraco.Web.UI.Client/src/packages/content/content-type/structure/content-type-structure-manager.class.ts:233

• The bulk load path ignores { data, error } from requestByUniques and only updates #dataTypeDetails via asObservable(). If the detail store context isn’t available (or the bulk response is partial / errored), asObservable() can be undefined or emit an empty array, leaving contentTypeDataTypeDetailOf(...).asPromise() waiting forever. Handle error, and populate #dataTypeDetails from the returned data (and/or create placeholders for missing uniques) so callers can fail fast instead of hanging.

				if (dataTypeUniques && dataTypeUniques.length > 0) {
					const { asObservable } = await this.#dataTypeDetailRepository.requestByUniques(dataTypeUniques);
					// TODO: We should avoid this check, but architectural we are missing a way to cancel previous requests. [NL]
					// It is not very likely that this happens, but we keep this check to avoid eventual race conditions. [NL]
					const currentDataTypeUniques = this.getContentTypeDataTypeUniques();
					if (
						dataTypeUniques.length !== currentDataTypeUniques.length ||
						!dataTypeUniques.every((unique) => currentDataTypeUniques.includes(unique))
					) {
						return;
					}
					if (asObservable) {
						this.observe(
							asObservable(),
							(dataTypeDetails) => {
								this.#dataTypeDetails.setValue(dataTypeDetails ?? []);
							},

[claude]

Claude encountered an error after 0s —— View job

---

I'll analyze this and get back to you.