Skip to content

V18: Beta UI adjustments - #22869

Merged
nielslyngsoe merged 56 commits into
release/18.0from
v18/hotfix/18-beta-ui-adjustments
Jun 5, 2026
Merged

V18: Beta UI adjustments#22869
nielslyngsoe merged 56 commits into
release/18.0from
v18/hotfix/18-beta-ui-adjustments

Merge branch 'release/18.0' into v18/hotfix/18-beta-ui-adjustments

72a89e9
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Code Health Review (release/18.0) failed May 31, 2026 in 2m 1s

CodeScene PR Check

Quality Gate Failed

Gates Failed
Enforce advisory code health rules (1 file with Complex Method, Complex Conditional, Primitive Obsession, String Heavy Function Arguments)

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Reason for failure
Enforce advisory code health rules Violations Code Health Impact
document-workspace.context.ts 4 advisory rules 8.48 Suppress

Quality Gate Profile: Clean Code Collective
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method document-workspace.context.ts: UmbDocumentWorkspaceContext.handleSaveAndPreview
  • Complex Method document-workspace.context.ts: UmbDocumentWorkspaceContext.constructor
  • Complex Conditional document-workspace.context.ts: UmbDocumentWorkspaceContext.handleSaveAndPreview
  • Primitive Obsession document-workspace.context.ts
  • String Heavy Function Arguments document-workspace.context.ts

Annotations

Check warning on line 366 in src/Umbraco.Web.UI.Client/src/packages/documents/documents/workspace/context/document-workspace.context.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Code Health Review (release/18.0)

❌ New issue: Complex Method

UmbDocumentWorkspaceContext.handleSaveAndPreview has a cyclomatic complexity of 13, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 201 in src/Umbraco.Web.UI.Client/src/packages/documents/documents/workspace/context/document-workspace.context.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Code Health Review (release/18.0)

❌ New issue: Complex Method

UmbDocumentWorkspaceContext.constructor has a cyclomatic complexity of 13, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 329 in src/Umbraco.Web.UI.Client/src/packages/documents/documents/workspace/context/document-workspace.context.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Code Health Review (release/18.0)

❌ New issue: Complex Conditional

UmbDocumentWorkspaceContext.handleSaveAndPreview has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.

Check warning on line 1 in src/Umbraco.Web.UI.Client/src/packages/documents/documents/workspace/context/document-workspace.context.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Code Health Review (release/18.0)

❌ New issue: Primitive Obsession

In this module, 61.1% of all function arguments are primitive types, threshold = 30.0%. The functions in this file have too many primitive types (e.g. int, double, float) in their function argument lists. Using many primitive types lead to the code smell Primitive Obsession. Avoid adding more primitive arguments.

Check warning on line 1 in src/Umbraco.Web.UI.Client/src/packages/documents/documents/workspace/context/document-workspace.context.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Code Health Review (release/18.0)

❌ New issue: String Heavy Function Arguments

In this module, 50.0% of all arguments to its 17 functions are strings. The threshold for string arguments is 39.0%. The functions in this file have a high ratio of strings as arguments. Avoid adding more.