Skip to content

Mocks: Add missing signalR property to mock server configuration response#22849

Merged
AndyButland merged 1 commit into
v17/devfrom
v17/bugfix/mock-server-configuration-signalr
May 14, 2026
Merged

Mocks: Add missing signalR property to mock server configuration response#22849
AndyButland merged 1 commit into
v17/devfrom
v17/bugfix/mock-server-configuration-signalr

Conversation

@leekelleher

@leekelleher leekelleher commented May 14, 2026

Copy link
Copy Markdown
Member

Description

GetServerConfigurationResponse was updated in #22700 to require a signalR.skipNegotiation property, but the corresponding MSW mock handler in server.handlers.ts was not updated to match. This caused a tsc compilation error when running npm run compile in src/Umbraco.Web.UI.Client.

This PR adds the missing property to the mock response with a default value of false (matching the production default).

Testing

  1. Check out this branch
  2. From src/Umbraco.Web.UI.Client, run npm run compile
  3. Confirm tsc completes without errors

…onse

The GetServerConfigurationResponse type was updated in #22700 to require
a signalR.skipNegotiation property, but the MSW mock handler was not
updated to match, causing a tsc compilation error.
Copilot AI review requested due to automatic review settings May 14, 2026 16:26
@claude

claude Bot commented May 14, 2026

Copy link
Copy Markdown

Claude finished @leekelleher's task in 51s —— View job


PR Review

Target: origin/v17/dev · Based on commit: 4ef96e15 · Classified as: Config-only (mock fixture sync)

Syncs the MSW mock handler for GET /server/configuration with the GetServerConfigurationResponse type, which gained a required signalR.skipNegotiation property in #22700. Without this, tsc fails because the mock object no longer satisfies the type.


No Critical, Important, or Suggestion findings. The value false correctly matches the production default for skipNegotiation.


Approved

This looks good to be merged as-is, but please do a manual sanity check and testing before merging.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the MSW mock for the server configuration endpoint in Umbraco.Web.UI.Client to align with the updated GetServerConfigurationResponse contract by adding the required signalR.skipNegotiation property (defaulting to false). This unblocks tsc compilation when using the mock handlers.

Changes:

  • Added the missing signalR: { skipNegotiation: false } field to the mocked /server/configuration response.
  • Ensured the mock response matches the generated ServerConfigurationResponseModel shape.

@leekelleher leekelleher changed the title Mocks: Add missing signalR property to mock server configuration response Mocks: Add missing signalR property to mock server configuration response May 14, 2026

@AndyButland AndyButland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @leekelleher - I've confirmed this has resolved the problem. Will cherry-pick for release/17.5.0 and release/18.0 (once have established it's needed).

@AndyButland AndyButland enabled auto-merge (squash) May 14, 2026 16:46
@AndyButland AndyButland merged commit 0f438c5 into v17/dev May 14, 2026
36 checks passed
@AndyButland AndyButland deleted the v17/bugfix/mock-server-configuration-signalr branch May 14, 2026 17:05
AndyButland pushed a commit that referenced this pull request May 14, 2026
…sponse (#22849)

Mocks: Add missing signalR property to mock server configuration response

The GetServerConfigurationResponse type was updated in #22700 to require
a signalR.skipNegotiation property, but the MSW mock handler was not
updated to match, causing a tsc compilation error.
@AndyButland

Copy link
Copy Markdown
Contributor

As discussed @leekelleher, cherry-picked to release/17.5.0 but still needs applying to the 18 release branch.

@leekelleher

Copy link
Copy Markdown
Member Author

Thanks @AndyButland. It turns out that the v18 branches already had this fix.

I think it was during another cherry-picked merge-conflict: 8495405#diff-ed76282a1e7134cafd99e718981ede396c603af9aa5605758053d1764183fc9a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants