Mocks: Add missing signalR property to mock server configuration response#22849
Conversation
…onse The GetServerConfigurationResponse type was updated in #22700 to require a signalR.skipNegotiation property, but the MSW mock handler was not updated to match, causing a tsc compilation error.
|
Claude finished @leekelleher's task in 51s —— View job PR ReviewTarget: Syncs the MSW mock handler for No Critical, Important, or Suggestion findings. The value ApprovedThis looks good to be merged as-is, but please do a manual sanity check and testing before merging. |
There was a problem hiding this comment.
Pull request overview
This PR fixes the MSW mock for the server configuration endpoint in Umbraco.Web.UI.Client to align with the updated GetServerConfigurationResponse contract by adding the required signalR.skipNegotiation property (defaulting to false). This unblocks tsc compilation when using the mock handlers.
Changes:
- Added the missing
signalR: { skipNegotiation: false }field to the mocked/server/configurationresponse. - Ensured the mock response matches the generated
ServerConfigurationResponseModelshape.
signalR property to mock server configuration response
AndyButland
left a comment
There was a problem hiding this comment.
Thanks @leekelleher - I've confirmed this has resolved the problem. Will cherry-pick for release/17.5.0 and release/18.0 (once have established it's needed).
|
As discussed @leekelleher, cherry-picked to |
|
Thanks @AndyButland. It turns out that the v18 branches already had this fix. I think it was during another cherry-picked merge-conflict: 8495405#diff-ed76282a1e7134cafd99e718981ede396c603af9aa5605758053d1764183fc9a |
Description
GetServerConfigurationResponsewas updated in #22700 to require asignalR.skipNegotiationproperty, but the corresponding MSW mock handler inserver.handlers.tswas not updated to match. This caused atsccompilation error when runningnpm run compileinsrc/Umbraco.Web.UI.Client.This PR adds the missing property to the mock response with a default value of
false(matching the production default).Testing
src/Umbraco.Web.UI.Client, runnpm run compiletsccompletes without errors