Skip to content

Content Editing: Fix save composition values on invariant content and save of default segment (closes #22800, #22865) #22846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyButland merged 6 commits into from
May 20, 2026
Merged

Content Editing: Fix save composition values on invariant content and save of default segment (closes #22800, #22865) #22846

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1786310
Fix edit of a variant property composed to an invariant document.
AndyButland May 14, 2026
8f0958f
Collapse multi-line guard comment to a single line per project policy.
AndyButland May 14, 2026
0b3245a
Add unit test coverage for invariant content with a culture-variant c…
AndyButland May 14, 2026
2609104
Merge branch 'v17/dev' into v17/bugfix/22800-save-value-from-composition
AndyButland May 18, 2026
51c3012
Remove null guard for segment variant documents, as null segment is t…
AndyButland May 18, 2026
af61937
update mock data and tests to include real compositions
madsrasmussen May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ...aco.Web.UI.Client/src/packages/content/content/workspace/content-detail-workspace-base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -686,9 +686,14 @@ export abstract class UmbContentDetailWorkspaceContextBase<
throw new Error(`Property alias "${alias}" not found.`);
}

// Effective variance is the intersection of the property's and the content type's variance —
// a variant property on an invariant content type (e.g. inherited from a variant composition)
// is effectively invariant and must be stored with a culture/segment-invariant variantId.
const contentTypeVariesByCulture = this.getVariesByCulture() ?? false;
const contentTypeVariesBySegment = this.getVariesBySegment() ?? false;
if (
(property.variesByCulture && variantId.isCultureInvariant()) ||
(property.variesBySegment && variantId.isSegmentInvariant())
(property.variesByCulture && contentTypeVariesByCulture && variantId.isCultureInvariant()) ||
(property.variesBySegment && contentTypeVariesBySegment && variantId.isSegmentInvariant())
) {
throw new Error(`Property alias "${alias}" requires a variantId.`);
}
Expand Down
Loading