Global Elements: Add umb-entity-frame component for entity references - #22821
Closed
leekelleher wants to merge 4 commits into
Closed
Global Elements: Add umb-entity-frame component for entity references#22821leekelleher wants to merge 4 commits into
umb-entity-frame component for entity references#22821leekelleher wants to merge 4 commits into
Conversation
|
Claude finished @leekelleher's task in 3m 56s —— View job PR Review Complete
Review posted. 3 suggestions filed; no critical or important issues found. Approved with Suggestions for improvement. |
umb-entity-frame component for entity references
This comment was marked as resolved.
This comment was marked as resolved.
Member
Author
|
Closing this PR, superseded by #22844 for v17.6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As part of the Global Elements phase 2 work (Reusable Content of Blocks, see #22448), we need UI to distinguish a referenced global element from a local block. Introducing an
<umb-entity-frame>component brings us a step closer towards this.Summary (AI/Claude generated 🤖)
umb-entity-framecomponent undersrc/packages/core/components/— a passive overlay that frames its parent with a rounded border and label tab.--umb-entity-frame-opacityCSS custom property (defaults to1); typical pattern is for the parent container to set it to0and toggle to1on:hoverand/or:focus-within.--umb-entity-frame-opacity,--umb-entity-frame-color, and--umb-entity-frame-border-width.Test Plan
Generic Components/Entity Frameand verify all 8 stories render correctlyOnHover,OnHoverOrFocus,WrappingButton,Nested) toggle visibility as expectedWithCustomColorstory renders with the purple theming (#7532c8)WithSlotstory shows the slotted icon + text instead of the label fallbacknpm test -- --files "**/entity-frame.test.ts"npx tsc --noEmit