Skip to content

Tiptap RTE: Ignore no-op transactions in onUpdate to prevent phantom dirty state (closes #22767) #22781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leekelleher merged 1 commit into from
May 11, 2026
Merged

Tiptap RTE: Ignore no-op transactions in onUpdate to prevent phantom dirty state (closes #22767) #22781

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...Umbraco.Web.UI.Client/src/packages/tiptap/components/input-tiptap/input-tiptap.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,10 @@
onContentError: ({ error }) => {
console.error('contentError', [error.message, error.cause]);
},
onUpdate: ({ editor }) => {
onUpdate: ({ editor, transaction }) => {
// Tiptap also fires `update` for no-op transactions (e.g. setEditable),
// which would otherwise dirty the workspace with a phantom change.
if (!transaction.docChanged) return;

Check warning on line 229 in src/Umbraco.Web.UI.Client/src/packages/tiptap/components/input-tiptap/input-tiptap.element.ts

View check run for this annotation

CodeScene Delta Analysis / CodeScene Code Health Review (v17/dev)

❌ Getting worse: Complex Method 

UmbInputTiptapElement.loadEditor increases in cyclomatic complexity from 17 to 18, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
this.#value = editor.getHTML();
this._runValidators();
this.dispatchEvent(new UmbChangeEvent());
Expand Down
Loading