Skip to content

Color Picker: Refresh stored label when data type label changes (closes #22741) #22761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iOvergaard merged 4 commits into from
May 7, 2026
Merged

Color Picker: Refresh stored label when data type label changes (closes #22741) #22761

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b3f1ca5
Update stored color label if changed on save of document with color p…
AndyButland May 7, 2026
7bdb5a5
Clarify intent of change event dispatch in label sync
AndyButland May 7, 2026
abb601e
Make comparison case insensitive.
AndyButland May 7, 2026
e95aef0
Added unit tests for new behaviour.
AndyButland May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ...ent/src/packages/property-editors/color-picker/property-editor-ui-color-picker.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ export class UmbPropertyEditorUIColorPickerElement
@property({ type: Object })
public override set value(value: UmbSwatchDetails | undefined) {
super.value = value ? this.#ensureHashPrefix(value) : undefined;
this.#syncLabelFromSwatches();
}
public override get value(): UmbSwatchDetails | undefined {
return super.value;
Expand Down Expand Up @@ -49,6 +50,16 @@ export class UmbPropertyEditorUIColorPickerElement

const swatches = config?.getValueByAlias<Array<UmbSwatchDetails>>('items') ?? [];
this._swatches = swatches.map((swatch) => this.#ensureHashPrefix(swatch));
this.#syncLabelFromSwatches();
}

#syncLabelFromSwatches() {
if (!this.value || this._swatches.length === 0) return;
const match = this._swatches.find((swatch) => swatch.value === this.value!.value);
if (match && match.label !== this.value.label) {
super.value = match;
this.dispatchEvent(new UmbChangeEvent());
}
Comment thread
AndyButland marked this conversation as resolved.
}
Comment thread
AndyButland marked this conversation as resolved.

Comment thread
AndyButland marked this conversation as resolved.
Outdated
#ensureHashPrefix(swatch: UmbSwatchDetails): UmbSwatchDetails {
Expand Down
Loading