Code Tidy: Remove obsolete MoveEventInfo.NewParent - #22728
Merged
AndyButland merged 5 commits intoMay 6, 2026
CodeScene Delta Analysis / CodeScene Code Health Review (v18/dev)
succeeded
May 6, 2026 in 1m 0s
CodeScene PR Check
Quality Gate Passed
(1 files improve in Code Health)
Gates Passed
See analysis details in CodeScene
View Improvements
| File | Code Health Impact | Categories Improved |
|---|---|---|
| MoveEventInfoTests.cs | 9.69 → 10.00 | Excess Number of Function Arguments |
Quality Gate Profile: Clean Code Collective
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
Details
✅ Improving Code Health:
- Complex Method DictionaryItemService.cs: MoveAsync
- Excess Number of Function Arguments MoveEventInfoTests.cs: Can_Equate_Move_Event_Infos
Annotations
Check notice on line 297 in src/Umbraco.Core/Services/DictionaryItemService.cs
codescene-delta-analysis / CodeScene Code Health Review (v18/dev)
✅ Getting better: Complex Method
MoveAsync decreases in cyclomatic complexity from 10 to 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 51 in tests/Umbraco.Tests.UnitTests/Umbraco.Core/Events/MoveEventInfoTests.cs
codescene-delta-analysis / CodeScene Code Health Review (v18/dev)
✅ No longer an issue: Excess Number of Function Arguments
Can_Equate_Move_Event_Infos is no longer above the threshold for number of arguments
Loading