Skip to content

Code Tidy: Remove unused obsoleted InstalledPackage mapping #22713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyButland merged 2 commits into from
May 5, 2026
Merged

Code Tidy: Remove unused obsoleted InstalledPackage mapping #22713

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8080b09
Remove unused obseleted InstalledPackage mapping
Migaroez May 5, 2026
8981f63
Fix up XML header documentation on PackageViewModelMapDefinition.
AndyButland May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 2 additions & 17 deletions src/Umbraco.Cms.Api.Management/Mapping/Package/PackageViewModelMapDefinition.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,13 @@
namespace Umbraco.Cms.Api.Management.Mapping.Package;

/// <summary>
/// Provides mapping configuration for converting package data to and from the <see cref="PackageViewModel"/>.
/// Provides mapping configuration for converting package data to and from the <see cref="PackageDefinitionResponseModel"/>.
/// </summary>
public class PackageViewModelMapDefinition : IMapDefinition
{
/// <summary>
/// Configures the object-object mappings for package-related models used in the management API.
/// This includes mappings between <see cref="PackageModelBase"/>, <see cref="PackageDefinition"/>,
/// <see cref="PackageDefinitionResponseModel"/>, <see cref="InstalledPackage"/>, and <see cref="PackageMigrationStatusResponseModel"/>.
/// This includes mappings between <see cref="PackageModelBase"/>, <see cref="PackageDefinition"/>, and <see cref="PackageDefinitionResponseModel"/>.
/// </summary>
/// <param name="mapper">The <see cref="IUmbracoMapper"/> instance used to register the mappings.</param>
public void DefineMaps(IUmbracoMapper mapper)
Expand All @@ -22,8 +21,6 @@ public void DefineMaps(IUmbracoMapper mapper)
mapper.Define<PackageDefinition, PackageDefinitionResponseModel>(
(_, _) => new PackageDefinitionResponseModel { Name = string.Empty, PackagePath = string.Empty },
Map);
mapper.Define<InstalledPackage, PackageMigrationStatusResponseModel>(
(_, _) => new PackageMigrationStatusResponseModel { PackageName = string.Empty }, Map);
}

// Umbraco.Code.MapAll -Id -PackageId -PackagePath
Expand Down Expand Up @@ -65,16 +62,4 @@ private static void Map(PackageDefinition source, PackageDefinitionResponseModel
target.Languages = source.Languages;
target.DictionaryItems = source.DictionaryItems;
}

// Umbraco.Code.MapAll
[Obsolete("Please use the IPackagePresentationFactory instead. Scheduled for removal in Umbraco 18.")]
private static void Map(InstalledPackage source, PackageMigrationStatusResponseModel target, MapperContext context)
{
if (source.PackageName is not null)
{
target.PackageName = source.PackageName;
}

target.HasPendingMigrations = source.HasPendingMigrations;
}
}
Loading