SignalR: Add configurable transport settings for load-balanced deployments without sticky sessions#22700
CodeScene PR Check
Quality Gate Failed
Gates Failed
(2 files with Large Method, Complex Method)
Gates Passed
See analysis details in CodeScene
Reason for failure
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| server-connection.ts | 1 advisory rule | 10.00 → 9.69 | Suppress |
| UmbracoBuilder.Configuration.cs | 1 advisory rule | 9.60 → 9.60 | Suppress |
Quality Gate Profile: Clean Code Collective
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
Details
🚩 Declining Code Health (highest to lowest):
- Large Method UmbracoBuilder.Configuration.cs: AddConfiguration
- Complex Method server-connection.ts: UmbServerConnection.setServerConfiguration
✅ Improving Code Health:
- Overall Code Complexity preview.context.ts
Annotations
Check warning on line 107 in src/Umbraco.Core/DependencyInjection/UmbracoBuilder.Configuration.cs
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ Getting worse: Large Method
AddConfiguration increases from 71 to 72 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
Check warning on line 104 in src/Umbraco.Web.UI.Client/src/packages/core/server/server-connection.ts
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Complex Method
UmbServerConnection.setServerConfiguration has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 1 in src/Umbraco.Web.UI.Client/src/packages/preview/context/preview.context.ts
codescene-delta-analysis / CodeScene Code Health Review (main)
✅ Getting better: Overall Code Complexity
The mean cyclomatic complexity decreases from 5.00 to 4.91, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.