Skip to content

Code Tidy: Remove package validation suppression files#22696

Merged
Zeegaan merged 1 commit into
v18/devfrom
v18/task/remove-supressions
May 5, 2026
Merged

Code Tidy: Remove package validation suppression files#22696
Zeegaan merged 1 commit into
v18/devfrom
v18/task/remove-supressions

Conversation

@AndyButland

@AndyButland AndyButland commented May 4, 2026

Copy link
Copy Markdown
Contributor

Description

Now that we are working towards the v18 major release, the CompatibilitySuppressions.xml baseline files saved during the v17 lifetime to permit breaking changes in package validation are no longer relevant and have been removed.

Note that EnablePackageValidation remains false in Directory.Build.props (see existing TODO (V18) comment) and will be re-enabled once 18.0.0 is released, at which point a fresh baseline can be generated.

Copilot AI review requested due to automatic review settings May 4, 2026 15:02
@claude

claude Bot commented May 4, 2026

Copy link
Copy Markdown

Claude finished @AndyButland's task in 1m 18s —— View job


PR Review

Target: origin/v18/dev · Based on commit: 5c5eccf1 · Skipped: 0 noise files · Classified as: Config-only

Removes four v17-era CompatibilitySuppressions.xml baseline files that suppressed package validation diagnostics accumulated during the v17 release cycle — no longer relevant now that the v18 major baseline is being established.


No issues found. This is a clean deletion of stale configuration artifacts. With EnablePackageValidation=false in Directory.Build.props (and the existing TODO (V18) comment to re-enable it post-release), removing these files has no effect on the current build and correctly sets up a clean state for the v18 baseline.


Approved

This looks good to be merged as-is, but please do a manual sanity check and testing before merging.

@AndyButland AndyButland changed the title Code Tidy: Remove v17 package validation suppression files Code Tidy: Remove package validation suppression files May 4, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes legacy CompatibilitySuppressions.xml baseline files that were used to suppress .NET package validation diagnostics during the v17 lifecycle, aligning the repo with the move toward the v18 major release and reducing maintenance noise.

Changes:

  • Removed v17-era package validation suppression baselines from src/ and tests/.
  • Eliminated now-empty suppression files that no longer provided value.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
tests/Umbraco.Tests.Integration/CompatibilitySuppressions.xml Removed historical package validation suppressions for integration test assembly.
tests/Umbraco.Tests.Common/CompatibilitySuppressions.xml Removed empty suppression baseline file.
src/Umbraco.Core/CompatibilitySuppressions.xml Removed empty suppression baseline file.
src/Umbraco.Cms.Api.Management/CompatibilitySuppressions.xml Removed historical package validation suppressions for Management API package.

@Zeegaan Zeegaan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 😁

@Zeegaan Zeegaan merged commit 6c2473a into v18/dev May 5, 2026
33 checks passed
@Zeegaan Zeegaan deleted the v18/task/remove-supressions branch May 5, 2026 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants