Code Tidy: Remove package validation suppression files#22696
Conversation
|
Claude finished @AndyButland's task in 1m 18s —— View job PR ReviewTarget: Removes four v17-era No issues found. This is a clean deletion of stale configuration artifacts. With ApprovedThis looks good to be merged as-is, but please do a manual sanity check and testing before merging. |
There was a problem hiding this comment.
Pull request overview
This PR removes legacy CompatibilitySuppressions.xml baseline files that were used to suppress .NET package validation diagnostics during the v17 lifecycle, aligning the repo with the move toward the v18 major release and reducing maintenance noise.
Changes:
- Removed v17-era package validation suppression baselines from
src/andtests/. - Eliminated now-empty suppression files that no longer provided value.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/Umbraco.Tests.Integration/CompatibilitySuppressions.xml | Removed historical package validation suppressions for integration test assembly. |
| tests/Umbraco.Tests.Common/CompatibilitySuppressions.xml | Removed empty suppression baseline file. |
| src/Umbraco.Core/CompatibilitySuppressions.xml | Removed empty suppression baseline file. |
| src/Umbraco.Cms.Api.Management/CompatibilitySuppressions.xml | Removed historical package validation suppressions for Management API package. |
Description
Now that we are working towards the v18 major release, the
CompatibilitySuppressions.xmlbaseline files saved during the v17 lifetime to permit breaking changes in package validation are no longer relevant and have been removed.Note that
EnablePackageValidationremainsfalseinDirectory.Build.props(see existingTODO (V18)comment) and will be re-enabled once 18.0.0 is released, at which point a fresh baseline can be generated.