Skip to content

Redirect Tracker: Prevent creation of redirects from unrouteable URLs (closes #22652, #22256)#22657

Merged
Zeegaan merged 3 commits into
mainfrom
v17/bugfix/22652-preview-generating-redirects
May 1, 2026
Merged

Redirect Tracker: Prevent creation of redirects from unrouteable URLs (closes #22652, #22256)#22657
Zeegaan merged 3 commits into
mainfrom
v17/bugfix/22652-preview-generating-redirects

Extend fix to handle case where a second, child page is "redirected" …

246ab37
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Code Health Review (main) failed Apr 30, 2026 in 41s

CodeScene PR Check

Quality Gate Failed

Gates Failed
Enforce advisory code health rules (1 file with Complex Conditional)

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Reason for failure
Enforce advisory code health rules Violations Code Health Impact
RedirectTracker.cs 1 advisory rule 7.89 → 7.82 Suppress

Quality Gate Profile: Clean Code Collective
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Conditional RedirectTracker.cs: CreateRedirects

Annotations

Check warning on line 303 in src/Umbraco.Infrastructure/Routing/RedirectTracker.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Code Health Review (main)

❌ New issue: Complex Conditional

CreateRedirects has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.