Code Tidy: Clean up further obsoleted code scheduled for removal in Umbraco 18 (IEmailSender, MemberConfigurationResponseModel, MediaPermissions)

[AndyButland]

Description

This is a further PR that removes obsolete members scheduled for removal in Umbraco 18, covering three independent cleanups bundled together.

1. IEmailSender

• Removed two obsolete SendAsync overloads:
  • SendAsync(EmailMessage, string)
  • SendAsync(EmailMessage, string, bool)
• Removed the default interface implementation on the modern overload SendAsync(EmailMessage, string, bool, TimeSpan?), which existed only to bridge the obsolete overloads.
• Updated the two implementations (EmailSender, NotImplementedEmailSender) to drop the obsolete overloads.
• No call-site updates needed - all production callers were already using the modern overload.

2. MemberConfigurationResponseModel

• Removed the obsolete empty MemberConfigurationResponseModel view model.
• Removed the orphaned ConfigurationMemberController whose only purpose was returning that empty model (corresponding to the GET /umbraco/management/api/v1/member/configuration endpoint).
• Removed CreateMemberConfigurationResponseModel() from IConfigurationPresentationFactory and its implementation in ConfigurationPresentationFactory.

3. MediaPermissions (in Umbraco.Cms.Core.Security)

• Removed the obsolete MediaPermissions class along with its Services.AddSingleton<MediaPermissions>() registration.
• Removed MediaPermissionsTests (7 tests covering the obsolete class).
• Added new MediaPermissionServiceTests covering the non-obsolete replacement IMediaPermissionService. The new test class mirrors all 7 original scenarios on the equivalent service methods (AuthorizeAccessAsync, AuthorizeRootAccessAsync, AuthorizeBinAccessAsync) and adds 5 further tests covering API surface that wasn't on the old class (multi-key authorize, empty-keys edge case, FilterAuthorizedAccessAsync).

Testing

Build checks should pass - solution should build and test suite should complete without failures.

[claude]

Claude encountered an error —— View job

---

I'll analyze this and get back to you.

[Copilot]

Pull request overview

Removes additional obsolete APIs/types scheduled for removal in Umbraco 18, including email sender overloads, an unused member-configuration management endpoint/model, and the legacy MediaPermissions class in favor of IMediaPermissionService.

Changes:

• Removed obsolete IEmailSender.SendAsync overloads and updated implementations accordingly.
• Removed the unused Management API member configuration endpoint/model and its presentation factory method.
• Removed obsolete MediaPermissions + DI registration, and replaced legacy tests with MediaPermissionServiceTests for IMediaPermissionService.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
tests/Umbraco.Tests.UnitTests/Umbraco.Core/Services/MediaPermissionServiceTests.cs	Adds unit coverage for IMediaPermissionService scenarios (including multi-key + filtering).
tests/Umbraco.Tests.UnitTests/Umbraco.Core/Security/MediaPermissionsTests.cs	Removes tests for the obsolete MediaPermissions class.
src/Umbraco.Infrastructure/Mail/EmailSender.cs	Drops obsolete SendAsync overload implementations.
src/Umbraco.Core/Security/MediaPermissions.cs	Removes the obsolete MediaPermissions class.
src/Umbraco.Core/Mail/NotImplementedEmailSender.cs	Drops obsolete SendAsync overloads, keeping the modern signature.
src/Umbraco.Core/Mail/IEmailSender.cs	Removes obsolete overloads and default interface bridging implementation.
src/Umbraco.Core/DependencyInjection/UmbracoBuilder.cs	Removes DI registration of the obsolete MediaPermissions.
src/Umbraco.Cms.Api.Management/ViewModels/Member/MemberConfigurationResponseModel.cs	Removes the obsolete/empty response model.
src/Umbraco.Cms.Api.Management/Factories/IConfigurationPresentationFactory.cs	Removes the member configuration presentation factory method.
src/Umbraco.Cms.Api.Management/Factories/ConfigurationPresentationFactory.cs	Removes the factory implementation for the member configuration model.
src/Umbraco.Cms.Api.Management/Controllers/Member/ConfigurationMemberController.cs	Removes the orphaned member configuration controller/endpoint.

Comments suppressed due to low confidence (1)

src/Umbraco.Cms.Api.Management/Factories/ConfigurationPresentationFactory.cs:83

• After removing the member configuration response model/controller, the generated backoffice client code still exposes this operation/model (e.g. src/Umbraco.Web.UI.Client/src/packages/core/backend-api/sdk.gen.ts#getMemberConfiguration and types.gen.ts still contain MemberConfigurationResponseModel). Please regenerate/update the OpenAPI-driven client artifacts (or remove the stale operation/model) so the repo doesn’t keep shipping a client that targets a now-removed endpoint (/umbraco/management/api/v1/member/configuration).

    /// <summary>
    /// Creates a <see cref="Umbraco.Cms.Api.Management.Models.MemberTypeConfigurationResponseModel"/> containing the reserved member field names.
    /// </summary>
    /// <returns>A <see cref="Umbraco.Cms.Api.Management.Models.MemberTypeConfigurationResponseModel"/> with reserved member field names populated.</returns>
    public MemberTypeConfigurationResponseModel CreateMemberTypeConfigurationResponseModel() =>
        new()
        {
            ReservedFieldNames = _reservedFieldNamesService.GetMemberReservedFieldNames(),
        };

[Zeegaan]

Looks great 💪