Variant-Selector: improve visual alignment for segments#22605
Conversation
|
Claude finished @nielslyngsoe's task in 2m 0s —— View job PR ReviewTarget: Adjusts visual alignment for segment variants in the variant selector: removes the DOM placeholder div from segment items (alignment now handled by CSS indentation) and replaces a hardcoded
No Critical issues. No Important issues. No Suggestions. ApprovedThis looks good to be merged as-is, but please do a manual sanity check and testing before merging. Labels applied: |
There was a problem hiding this comment.
Pull request overview
Updates the workspace split-view variant selector styling to better align segment (sub-variant) rows within the variant dropdown in the Umbraco backoffice UI.
Changes:
- Adjusts segment-variant rendering to not insert the
expand-areaplaceholder in most cases. - Refines CSS padding rules for culture/segment rows and
add-moderows to improve horizontal alignment. - Replaces a hardcoded icon margin with a design-token-based spacing value.
Co-authored-by: Copilot <copilot@github.com>
AndyButland
left a comment
There was a problem hiding this comment.
Thanks @nielslyngsoe, this looks good to me. Took me a moment to spot the difference but from my before:
And my after:
I can see the intend of the final, non-created language variant is corrected now.
Improves the variant selector alignment for segments, with this as the result: