Skip to content

Variant-Selector: improve visual alignment for segments#22605

Merged
nielslyngsoe merged 3 commits into
mainfrom
v17/improvement/adjust-variant-selector-for-segments
Apr 26, 2026
Merged

Variant-Selector: improve visual alignment for segments#22605
nielslyngsoe merged 3 commits into
mainfrom
v17/improvement/adjust-variant-selector-for-segments

Conversation

@nielslyngsoe

Copy link
Copy Markdown
Member

Improves the variant selector alignment for segments, with this as the result:

image

Copilot AI review requested due to automatic review settings April 24, 2026 21:18
@claude

claude Bot commented Apr 24, 2026

Copy link
Copy Markdown

Claude finished @nielslyngsoe's task in 2m 0s —— View job


PR Review

Target: origin/main · Based on commit: 76f0001c

Adjusts visual alignment for segment variants in the variant selector: removes the DOM placeholder div from segment items (alignment now handled by CSS indentation) and replaces a hardcoded 21px margin with a design token.

  • Other changes: Visual-only — indentation of segment variant rows in the dropdown changes; the empty expand-area placeholder div is no longer inserted for created segment variants.

No Critical issues. No Important issues. No Suggestions.


Approved

This looks good to be merged as-is, but please do a manual sanity check and testing before merging.


Labels applied: area/frontend, category/ux, category/ui

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the workspace split-view variant selector styling to better align segment (sub-variant) rows within the variant dropdown in the Umbraco backoffice UI.

Changes:

  • Adjusts segment-variant rendering to not insert the expand-area placeholder in most cases.
  • Refines CSS padding rules for culture/segment rows and add-mode rows to improve horizontal alignment.
  • Replaces a hardcoded icon margin with a design-token-based spacing value.

nielslyngsoe and others added 2 commits April 24, 2026 23:24
Co-authored-by: Copilot <copilot@github.com>
@nielslyngsoe nielslyngsoe enabled auto-merge (squash) April 24, 2026 21:24

@AndyButland AndyButland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nielslyngsoe, this looks good to me. Took me a moment to spot the difference but from my before:

image

And my after:

image

I can see the intend of the final, non-created language variant is corrected now.

@nielslyngsoe nielslyngsoe merged commit cb1bebf into main Apr 26, 2026
29 checks passed
@nielslyngsoe nielslyngsoe deleted the v17/improvement/adjust-variant-selector-for-segments branch April 26, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants