Migrations: Fix raw SQL with ISqlSyntaxProvider table and column quoting (closes #22603)

[idseefeld]

This closes issue #22603

Details will be provided by Copilot😉

[github-actions]

Hi there @idseefeld, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[Copilot]

Pull request overview

Updates an existing V_17_4_0 upgrade migration to correctly escape table/column identifiers in its raw SQL using ISqlSyntaxProvider, improving compatibility with database providers where unescaped identifiers can break statements (issue #22603).

Changes:

• Pull ISqlSyntaxProvider from database.SqlContext.SqlSyntax inside the migration.
• Quote table and column names in the raw UPDATE statement via GetQuotedTableName() / GetQuotedColumnName().

[AndyButland]

As we've built 17.4 for internal testing now @idseefeld, I'd like to not merge anything else into it unless it's something specifically broken since 17.3. Looks to me the migration fix in this PR matches that case, but I don't think the MemberFilterRepository changes does. Do you think you could separate this PR into two please - one for 17.4 that just has the minimal changes to fix the migration and one for existing concerns for 17.5 please?

Obviously we need to try to get better to remember quoting the column names. I'll try to keep a better eye on this moving forward.

[idseefeld]

@AndyButland I'll separate this PR as you suggested.
Indeed it would be helpful when you could have an eye on raw sql updates too.

[AndyButland]

Thanks @idseefeld - fix looks correct to me having carefully checked over all the replacements.