Skip to content

Migrations: Align type attribute casing in locallink migration for integer-based legacy links (closes #22597) #22599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyButland merged 2 commits into from
Apr 27, 2026
Merged

Migrations: Align type attribute casing in locallink migration for integer-based legacy links (closes #22597) #22599

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55efbc1
Align GUID-via-UDI and integer locallink sources in migration to cons…
AndyButland Apr 24, 2026
7f87f6b
Handle Pascal cased type attributes from local links.
AndyButland Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/Umbraco.Infrastructure/Migrations/Upgrade/V_15_0_0/LocalLinks/LocalLinkProcessor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,17 +135,19 @@ public string ProcessStringValue(string input)

private (Guid Key, string EntityType)? CreateIntBasedKeyType(int id)
{
// very old data, best effort replacement
// very old data, best effort replacement.
// entity type must match the lowercase UDI entity type, which is what the tiptap RTE
// expects in the "type" attribute (and what the UDI-based branch above produces).
Attempt<Guid> documentAttempt = _idKeyMap.GetKeyForId(id, UmbracoObjectTypes.Document);
if (documentAttempt.Success)
{
return (Key: documentAttempt.Result, EntityType: UmbracoObjectTypes.Document.ToString());
return (Key: documentAttempt.Result, EntityType: Constants.UdiEntityType.Document);
}

Attempt<Guid> mediaAttempt = _idKeyMap.GetKeyForId(id, UmbracoObjectTypes.Media);
if (mediaAttempt.Success)
{
return (Key: mediaAttempt.Result, EntityType: UmbracoObjectTypes.Media.ToString());
return (Key: mediaAttempt.Result, EntityType: Constants.UdiEntityType.Media);
}

return null;
Expand Down
8 changes: 5 additions & 3 deletions ...Infrastructure/Migrations/Upgrade/V_15_0_0/LocalLinks/LocalLinkProcessorForFaultyLinks.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,17 +72,19 @@ public string ProcessStringValue(string input)

private (Guid Key, string EntityType)? CreateIntBasedKeyType(int id)
{
// very old data, best effort replacement
// very old data, best effort replacement.
// entity type must match the lowercase UDI entity type, which is what the tiptap RTE
// expects in the "type" attribute.
Attempt<Guid> documentAttempt = _idKeyMap.GetKeyForId(id, UmbracoObjectTypes.Document);
if (documentAttempt.Success)
{
return (Key: documentAttempt.Result, EntityType: UmbracoObjectTypes.Document.ToString());
return (Key: documentAttempt.Result, EntityType: Constants.UdiEntityType.Document);
}

Attempt<Guid> mediaAttempt = _idKeyMap.GetKeyForId(id, UmbracoObjectTypes.Media);
if (mediaAttempt.Success)
{
return (Key: mediaAttempt.Result, EntityType: UmbracoObjectTypes.Media.ToString());
return (Key: mediaAttempt.Result, EntityType: Constants.UdiEntityType.Media);
}

return null;
Expand Down
10 changes: 5 additions & 5 deletions tests/Umbraco.Tests.UnitTests/Umbraco.Infrastructure/Migrations/LocalLinkProcessorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,13 +88,13 @@ public void ProcessStringValue_IntegerDocumentLink_ConvertsToGuidWithType()
var result = processor.ProcessStringValue(input);

Assert.AreEqual(
$@"<a href=""{{localLink:{documentKey}}}"" type=""Document"">link</a>",
$@"<a href=""{{localLink:{documentKey}}}"" type=""document"">link</a>",
result);
}

/// <summary>
/// Verifies that an integer-based link that resolves to media (not document)
/// is converted with the correct "Media" type attribute.
/// is converted with the correct "media" type attribute.
/// </summary>
[Test]
public void ProcessStringValue_IntegerMediaLink_ConvertsToGuidWithType()
Expand All @@ -115,7 +115,7 @@ public void ProcessStringValue_IntegerMediaLink_ConvertsToGuidWithType()
var result = processor.ProcessStringValue(input);

Assert.AreEqual(
$@"<a href=""{{localLink:{mediaKey}}}"" type=""Media"">link</a>",
$@"<a href=""{{localLink:{mediaKey}}}"" type=""media"">link</a>",
result);
}

Expand Down Expand Up @@ -305,7 +305,7 @@ public void ProcessStringValue_IntegerLink_WithFragment_PreservesFragment()
var result = processor.ProcessStringValue(input);

Assert.AreEqual(
$@"<a href=""{{localLink:{documentKey}}}#anchor"" type=""Document"">link</a>",
$@"<a href=""{{localLink:{documentKey}}}#anchor"" type=""document"">link</a>",
result);
}

Expand All @@ -328,7 +328,7 @@ public void ProcessStringValue_IntegerLink_WithQueryString_PreservesQueryString(
var result = processor.ProcessStringValue(input);

Assert.AreEqual(
$@"<a href=""{{localLink:{documentKey}}}?page=2"" type=""Document"">link</a>",
$@"<a href=""{{localLink:{documentKey}}}?page=2"" type=""document"">link</a>",
result);
}

Expand Down
Loading