Skip to content

Performance: Avoid allocating a string if _publishedContentCache has a cached version in MediaCacheService #22535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyButland merged 2 commits into from
Apr 20, 2026

Clarified comment, used GetCacheKey method from location where string…

9cca8d4
Select commit
Loading
Failed to load commit list.
Merged

Performance: Avoid allocating a string if _publishedContentCache has a cached version in MediaCacheService #22535

Clarified comment, used GetCacheKey method from location where string…
9cca8d4
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Code Health Review (main) succeeded Apr 20, 2026 in 48s

CodeScene PR Check

Quality Gate Passed

Code Health Improved (1 files improve in Code Health)

Gates Passed
4 Quality Gates Passed

See analysis details in CodeScene

View Improvements
File Code Health Impact Categories Improved
MediaCacheService.cs 9.39 → 9.69 Primitive Obsession

Quality Gate Profile: Clean Code Collective
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.

Details

✅ Improving Code Health:

  • Primitive Obsession MediaCacheService.cs

Annotations

Check notice on line 1 in src/Umbraco.PublishedCache.HybridCache/Services/MediaCacheService.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Code Health Review (main)

✅ No longer an issue: Primitive Obsession 

The ratio of primivite types in function arguments is no longer above the threshold
View more details on CodeScene Delta Analysis