Property Editor UI Picker: Implement fuzzy search#22468
Merged
Conversation
…erty-editor-ui-search
Contributor
There was a problem hiding this comment.
Pull request overview
Implements fuzzy search across the Property Editor UI picker (and the Data-Type Flow picker’s “create new configuration” UI list), and extends the icon picker with a richer search experience backed by additional icon metadata.
Changes:
- Add reusable
levenshtein+fuzzystring utilities (with tests) and expose them via the core utils barrel. - Introduce cancellable, yield-to-event-loop search controllers for property-editor UIs and icons (with tests).
- Integrate the new search controllers into the Data-Type Picker Flow modal, Property Editor UI Picker modal, and Icon Picker modal (plus minor UI style tweaks).
Reviewed changes
Copilot reviewed 18 out of 22 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Umbraco.Web.UI.Client/src/packages/data-type/modals/data-type-picker-flow/data-type-picker-flow-modal.element.ts | Uses UmbPropertyEditorUISearchController to fuzzy-search property editor UIs in the flow modal. |
| src/Umbraco.Web.UI.Client/src/packages/data-type/modals/data-type-picker-flow/data-type-picker-flow-data-type-picker-modal.element.ts | Minor CSS tweak to avoid label clipping. |
| src/Umbraco.Web.UI.Client/src/packages/core/utils/string/levenshtein/levenshtein.function.ts | Adds Levenshtein distance + similarity utilities. |
| src/Umbraco.Web.UI.Client/src/packages/core/utils/string/levenshtein/levenshtein.function.test.ts | Tests for Levenshtein utilities. |
| src/Umbraco.Web.UI.Client/src/packages/core/utils/string/levenshtein/index.ts | Barrel export for Levenshtein utilities. |
| src/Umbraco.Web.UI.Client/src/packages/core/utils/string/fuzzy/fuzzy.function.ts | Adds tokenization + fuzzy match scoring helpers. |
| src/Umbraco.Web.UI.Client/src/packages/core/utils/string/fuzzy/fuzzy.function.test.ts | Tests for fuzzy helpers. |
| src/Umbraco.Web.UI.Client/src/packages/core/utils/string/fuzzy/index.ts | Barrel export for fuzzy helpers. |
| src/Umbraco.Web.UI.Client/src/packages/core/utils/string/index.ts | Exposes new fuzzy and levenshtein modules via utils barrel. |
| src/Umbraco.Web.UI.Client/src/packages/core/property-editor/ui-picker-modal/property-editor-ui-search.controller.ts | New cancellable fuzzy search controller for property editor UIs. |
| src/Umbraco.Web.UI.Client/src/packages/core/property-editor/ui-picker-modal/property-editor-ui-search.controller.test.ts | Tests for property editor UI search controller behavior (ranking, fuzzy, abort). |
| src/Umbraco.Web.UI.Client/src/packages/core/property-editor/ui-picker-modal/property-editor-ui-picker-modal.element.ts | Integrates fuzzy search + debounced input into property editor UI picker modal. |
| src/Umbraco.Web.UI.Client/src/packages/core/property-editor/ui-picker-modal/index.ts | Exports the new search controller. |
| src/Umbraco.Web.UI.Client/src/packages/core/icon-registry/types.ts | Extends icon definitions with optional keywords, groups, related. |
| src/Umbraco.Web.UI.Client/src/packages/core/icon-registry/icon-picker-modal/icon-search.controller.ts | New cancellable fuzzy search controller for icons (includes related icon expansion). |
| src/Umbraco.Web.UI.Client/src/packages/core/icon-registry/icon-picker-modal/icon-search.controller.test.ts | Tests for icon search controller behavior (ranking, fuzzy, groups, related, abort). |
| src/Umbraco.Web.UI.Client/src/packages/core/icon-registry/icon-picker-modal/icon-picker-modal.element.ts | Switches icon filtering to use the new search controller + debounced input. |
| src/Umbraco.Web.UI.Client/devops/icons/todo_implement_this_data_thesaurus.json | Removes large placeholder thesaurus dataset file. |
| src/Umbraco.Web.UI.Client/devops/icons/index.js | Merges Lucide upstream tags/categories into generated icon dictionary metadata. |
…erty-editor-ui-search
# Conflicts: # src/Umbraco.Web.UI.Client/src/packages/core/icon-registry/icon-picker-modal/icon-picker-modal.element.ts # src/Umbraco.Web.UI.Client/src/packages/core/icon-registry/icons.ts
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Replace incorrect 'deactive' keyword with 'inactive' and add 'deactivated' to the toggle property editor manifest.
madsrasmussen
approved these changes
May 4, 2026
This was referenced Jun 26, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements Fuzzy search to the Property Editor UI Picker and adds Keywords to it, and the one taking part in the Data-Type Flow Picker.
Also adds suggestions to the Data-Type Flow Picker based on the current Property Name
Review by searching for a Property Editor, verifying that results are meaningful