Update npm dependencies for v17.4.0-rc

[NguyenThuyLan]

Description

Summary
Update development dependencies to their latest compatible versions, including both minor/patch updates and major version bumps where appropriate.

Changes
Major version bumps:

@eslint/js 
eslint 
eslint-plugin-jsdoc 
eslint-plugin-storybook 
storybook 
@storybook/addon-a11y 
@storybook/addon-docs 
@storybook/addon-links 
@storybook/web-components-vite 
globals 
prettier
marked

Minor/patch updates:

@babel/core 
@playwright/test 
@types/chai 
@web/dev-server-esbuild 
babel-loader 
cssnano 
eslint-plugin-lit 
eslint-plugin-wc 
msw
postcss 
semver 
typedoc 
dompurify

Testing
npm run build passes
npm run dev — backoffice UI loads correctly

[Copilot]

Pull request overview

Updates the backoffice (npm) dependency set for the v17.4.0-rc line, aligning multiple workspace packages and making small TypeScript cleanups to keep the codebase compatible with updated toolchain/linting.

Changes:

• Bump a wide range of root devDependencies (ESLint/Storybook/Prettier/etc.) and several workspace package dependencies (e.g., TipTap, marked, dompurify, diff).
• Apply small TypeScript refactors (mostly removing redundant initializers and adding explicit types) across several packages.
• Reclassify icon-ball to the simpleIcons section in the icon registry data.

Reviewed changes

Copilot reviewed 19 out of 20 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/Umbraco.Web.UI.Client/package.json	Major/minor devDependency updates for the backoffice toolchain.
src/Umbraco.Web.UI.Client/src/packages/core/package.json	Bumps diff, @hey-api/openapi-ts, and icon-source dev deps.
src/Umbraco.Web.UI.Client/src/packages/tiptap/package.json	Updates TipTap dependencies to 3.22.3.
src/Umbraco.Web.UI.Client/src/external/marked/package.json	Updates marked to ^18.0.0.
src/Umbraco.Web.UI.Client/src/external/dompurify/package.json	Updates dompurify to ^3.4.0.
src/Umbraco.Web.UI.Client/src/packages/tiptap/extensions/block/block.tiptap-toolbar-api.ts	Removes redundant = undefined initializer.
src/Umbraco.Web.UI.Client/src/packages/property-editors/date-time/property-editor-ui-date-time-picker-base.ts	Adds explicit typing for timeZoneToStore.
src/Umbraco.Web.UI.Client/src/packages/members/member/repository/detail/member-detail.server.data-source.ts	Simplifies scaffold icon retrieval by using a const.
src/Umbraco.Web.UI.Client/src/packages/media/media/repository/detail/media-detail.server.data-source.ts	Simplifies scaffold icon/collection retrieval and removes an unused type import.
src/Umbraco.Web.UI.Client/src/packages/documents/documents/repository/detail/document-detail.server.data-source.ts	Simplifies scaffold icon/collection retrieval and removes an unused type import.
src/Umbraco.Web.UI.Client/src/packages/media/media/components/input-image-cropper/image-cropper.element.ts	Tightens local variable typing for calculations and fixed-position data.
src/Umbraco.Web.UI.Client/src/packages/media/media/components/input-image-cropper/image-cropper-preview.element.ts	Tightens local variable typing for preview calculations.
src/Umbraco.Web.UI.Client/src/packages/core/sorter/sorter.controller.ts	Tightens local variable typing in placement/auto-scroll code paths.
src/Umbraco.Web.UI.Client/src/packages/core/search/search-modal/search-modal.element.ts	Simplifies local variable initialization for extension API creation.
src/Umbraco.Web.UI.Client/src/packages/core/router/router-slot/util/shadow.ts	Replaces pre-increment with roots + 1 in recursive traversal.
src/Umbraco.Web.UI.Client/src/packages/core/resources/try-execute/try-execute.controller.ts	Adjusts local variable declaration style in error notification handler.
src/Umbraco.Web.UI.Client/src/packages/core/icon-registry/icon-dictionary.json	Moves icon-ball entry from lucide to simpleIcons.
src/Umbraco.Web.UI.Client/src/packages/clipboard/property/context/clipboard.property-context.ts	Removes redundant empty-array initialization prior to assignment.
src/Umbraco.Web.UI.Client/src/mocks/handlers/document/publishing.handlers.ts	Adds cause to thrown errors when rethrowing non-Error failures.

[claude]

---

PR Review

Target: main · Based on commit: 12426c31c0
Skipped: 1 file out of 20 total (package-lock.json — noise)

Updates frontend devDependencies and a handful of production dependencies to their latest versions for v17.4.0-rc, with accompanying ESLint-driven code fixes (removing redundant initializations, let→const improvements, improved error chaining).

• Other changes: icon-ball (Dribbble) moved from the Lucide section to simpleIcons in icon-dictionary.json — a correct response to Dribbble being dropped from lucide-static 1.x. The alias is preserved so no consumer-visible breakage.

---

Suggestions

• src/packages/core/package.json:11: diff 8→9 major bump in a production dependency — peer dep range narrows for the published package. See inline comment.
• src/packages/core/package.json:13: @hey-api/openapi-ts ^0.85→^0.96 narrows the published peer dep range; low runtime risk but worth release notes. See inline comment.
• src/packages/tiptap/package.json:9: Tiptap 3.16→3.22.3 (6 minor versions) — suggest a quick RTE smoke-test before tagging rc. See inline comment.

---

Approved with Suggestions for improvement

Good to go, but please carefully consider the importance of the suggestions.

[iOvergaard]

@claude please review this again after the new changes since your last review and take special care around the icon auto-generated files.

[claude]

Review posted - see below for full findings on PR 22464 npm dep update.

[claude]

Review: Good dep maintenance PR. See summary in separate comment.

[claude]

Review Summary

This PR updates dev dependencies to their latest versions for v17.4.0-rc. The non-lockfile changes are clean and well-structured.

Good changes

• Error cause chaining in publishing.handlers.ts — { cause: error } improves debuggability of MSW mock errors.
• ++roots → roots + 1 in shadow.ts — avoids inadvertent mutation of the function argument in a recursive call.
• let-with-initializer → let-with-type across multiple files (sorter.controller.ts, image-cropper elements, search-modal, date-time picker, tiptap toolbar) — all safe. TypeScript control-flow analysis confirms every code path assigns before use.
• let → const in document/media/member data sources — correct, the variables are only assigned once.
• tsconfig exclude — adding node_modules, dist, dist-cms, mocks/tools to both the generator and the generated file is a good hygiene fix.
• Removing unused UmbReferenceByUnique imports — clean.

Items to verify

1. marked major bump (17 → 18) — runtime dependency

src/external/marked/package.json bumps marked from ^17.0.1 to ^18.0.0. This is a runtime package that ships via the importmap and renders markdown in the backoffice. The test checklist covers build and dev server startup — could you also confirm that backoffice screens which render markdown (package descriptions, help text, etc.) were manually tested?

2. TipTap bump (3.16.0 → 3.22.3) — core RTE runtime dependency

src/packages/tiptap/package.json jumps 6 minor versions. TipTap drives the RTE; minor releases can still include schema or command behaviour changes. Was the RTE tested end-to-end (inserting content, tables, images, embedded blocks) after this bump?

3. try-execute.controller.ts — default fallback message removed

Both if/else branches do assign message before it is used, so TypeScript is satisfied. However, the removed default ('A fatal server error occurred. If this continues, please reach out to your administrator.') acted as a safety net for cases where apiError.problemDetails.title is an empty string. If that happens, the error notification body will be blank. Low risk, but worth considering keeping the default as the initial value.

---

Nit: Many icon files are reformatted by the prettier 3.6.2 → 3.8.2 bump. No functional issue, just makes the diff noisier for reviewers.

Overall a solid maintenance PR. The main asks are manual testing confirmation for marked and TipTap (both runtime deps), and a consideration for restoring the fallback error message.

[iOvergaard]

I've tested Marked and Tiptap, regenerated the icon files and MSW and openapi SDK files. It all looks pretty solid.