Icons: developer icon manager - #22437
Merged
Merged
CodeScene Delta Analysis / CodeScene Code Health Review (main)
failed
May 7, 2026 in 1m 13s
CodeScene PR Check
Quality Gate Failed
Gates Failed
(1 file with Bumpy Road Ahead)
(2 files with Large Method, Complex Method)
Gates Passed
See analysis details in CodeScene
Reason for failure
| Enforce critical code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| icon-manager-app.element.ts | 1 critical rule | 9.54 | Suppress |
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| icon-editor.element.ts | 1 advisory rule | 9.29 | Suppress |
| icon-manager-app.element.ts | 1 advisory rule | 9.54 | Suppress |
Quality Gate Profile: Clean Code Collective
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
Details
🚩 Declining Code Health (highest to lowest):
- Large Method icon-editor.element.ts: IconEditorElement.render
- Complex Method icon-manager-app.element.ts: IconManagerAppElement.loadData
- Bumpy Road Ahead icon-manager-app.element.ts: IconManagerAppElement.loadData
Annotations
Check warning on line 230 in src/Umbraco.Web.UI.Client/devops/icon-manager/icon-editor.element.ts
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Large Method
IconEditorElement.render has 129 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Complex Method
IconManagerAppElement.loadData has a cyclomatic complexity of 11, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Bumpy Road Ahead
IconManagerAppElement.loadData has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is 2 blocks per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Loading