Conversation
AndyButland
requested changes
Apr 10, 2026
Contributor
AndyButland
left a comment
AndyButland
left a comment
There was a problem hiding this comment.
Looks good apart from some code that was previously there that I think you need to remove to realise the performance benefit. I'll give it a test now.
Co-authored-by: Andy Butland <abutland73@gmail.com>
…vements-with-elements' into v18/task/align-performance-improvements-with-elements
AndyButland
approved these changes
Apr 10, 2026
Contributor
AndyButland
left a comment
AndyButland
left a comment
There was a problem hiding this comment.
Tests out as expected, so please feel free to merge once you've decided on where to go with the unit tests suggestion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This PR mirrors the (relevant)
ContentPermissionServiceperformance improvements from #21470 to theElementPermissionService.Specifically, the use of
IEntityService.GetAllPaths()when authorizing for specific keys.Since the
ElementPermissionServiceis concerned with both containers and element, new overloads forIEntityService.GetAllPaths()andIEntityRepository.GetAllPaths()have been introduced, allowing for fetching the paths of multiple object types in one query.Testing this PR
Verify that element permissions still work - for example, remove element delete permissions for the admin user group and verify that element deletion is no longer possible (note: the UI still permits the action, but the API should respond in kind with a 403).