Unit tests: Add test coverage for ContentPermissionService#22373
Merged
AndyButland merged 3 commits intomainfrom Apr 8, 2026
Merged
Unit tests: Add test coverage for ContentPermissionService#22373AndyButland merged 3 commits intomainfrom
ContentPermissionService#22373AndyButland merged 3 commits intomainfrom
Conversation
AndyButland
changed the title
ContentPermissionService
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new unit test suite for ContentPermissionService to restore/extend coverage after removal of the obsolete ContentPermissions.CheckPermissions tests.
Changes:
- Introduces 17 unit tests covering
AuthorizeAccessAsync,AuthorizeRootAccessAsync,AuthorizeBinAccessAsync, andAuthorizeCultureAccessAsync. - Adds helpers for constructing users, language access, permissions, and
TreeEntityPathtest data.
tests/Umbraco.Tests.UnitTests/Umbraco.Core/Services/ContentPermissionServiceTests.cs
Outdated
Show resolved
Hide resolved
tests/Umbraco.Tests.UnitTests/Umbraco.Core/Services/ContentPermissionServiceTests.cs
Outdated
Show resolved
Hide resolved
tests/Umbraco.Tests.UnitTests/Umbraco.Core/Services/ContentPermissionServiceTests.cs
Outdated
Show resolved
Hide resolved
Migaroez
approved these changes
Apr 8, 2026
Contributor
Migaroez
left a comment
Migaroez
left a comment
There was a problem hiding this comment.
Looks like sensible tests, the only comment I have is the use of repeated paths and ids without meaning. Might be a good idea to put them in local consts so that the code is easier to read.
Contributor
Author
|
Good idea, I'll make that update before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds unit tests for
ContentPermissionService, which was previously not covered by automated tests.This closes the test coverage gap identified when
ContentPermissionsTests(testing the now-obsoleteContentPermissions.CheckPermissions) was removed in #22335.Testing
Verify all 17 tests pass via the build pipeline.