Content Editor: Fix workspace footer breadcrumb overflow hiding (closes #20132)#22323
Conversation
leekelleher
left a comment
There was a problem hiding this comment.
@engijlr I've tested this out and having mixed success with it. Sometimes it will show the breadcrumb as collapsed, then when I navigate elsewhere and return to it (or reload the page), the breadcrumb will take up 100% of the screen width, shifting the left-side/tree, and right/workspace-actions off-screen.
I've tried taking a look into a resolution/workaround, but I got slightly lost with where UUI and CMS components overlap. 😕
|
Hey @leekelleher thank you so much for testing the PR. It was a bit difficult for me to reproduce the issue and when I finally did it was very inconsistent 😞. Doing some investigation, it seems the main problem is in the responsive container. I made a PR in the UI library to fix it: [umbraco/Umbraco.UI/pull/1359]. I will mark this as a draft in the meantime but I could not reproduce the issue in the isolated storybook setup, I hope it works 🤞 |
|
@engijlr I noticed a comment added to the original issue, #20132 (comment), about the |
|
Claude finished @engijlr's task in 2m 23s —— View job PR Review
PR ReviewTarget: Fixes breadcrumb overflow in the workspace footer by adding Suggestions
No breaking changes detected — these are purely internal Approved with Suggestions for improvementGood to go from a code-correctness standpoint, but please carefully consider the completeness question raised above regarding the UUI library dependency before merging. |
|
Hey @leekelleher the changes from the UI library are now applied to the backoffice. I think this is ready for another review, when you have the time of course. In my case is working fine, I tried the reload and resize and seems to work fine. But let me know 😄 |
|
@engijlr Does this PR need to re-target v18 ( |
|
You are right @leekelleher I just rebase it |
leekelleher
left a comment
There was a problem hiding this comment.
Tested out, breadcrumb collapsing working great! 🚀
Summary
min-width: 0andoverflow: hiddento bothumb-workspace-breadcrumbandumb-workspace-variant-menu-breadcrumbflex-direction: row-reverseworkaround from the variant breadcrumb that was masking the issueScreenshots
Test plan
Fixed: #20132