Skip to content

Segments: Preserve segmented property values after save (closes #22166) - #22173

Merged
nielslyngsoe merged 5 commits into
mainfrom
v17/bugfix/22166-segmented-property-values
Apr 24, 2026
Merged

Segments: Preserve segmented property values after save (closes #22166)#22173
nielslyngsoe merged 5 commits into
mainfrom
v17/bugfix/22166-segmented-property-values

Addressed feedback from code review.

04fdc3e
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Code Health Review (main) failed Mar 18, 2026 in 42s

CodeScene PR Check

Quality Gate Failed

Gates Failed
Enforce advisory code health rules (1 file with Complex Method, Overall Code Complexity)

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Reason for failure
Enforce advisory code health rules Violations Code Health Impact
content-detail-workspace-base.ts 2 advisory rules 6.90 → 6.47 Suppress

Quality Gate Profile: Clean Code Collective
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.

Details

🚩 Declining Code Health (highest to lowest):

  • Overall Code Complexity content-detail-workspace-base.ts
  • Complex Method content-detail-workspace-base.ts: _processIncomingData

Annotations

Check warning on line 519 in src/Umbraco.Web.UI.Client/src/packages/content/content/workspace/content-detail-workspace-base.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Code Health Review (main)

❌ Getting worse: Complex Method

_processIncomingData increases in cyclomatic complexity from 9 to 11, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 1 in src/Umbraco.Web.UI.Client/src/packages/content/content/workspace/content-detail-workspace-base.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Code Health Review (main)

❌ New issue: Overall Code Complexity

This module has a mean cyclomatic complexity of 4.02 across 41 functions. The mean complexity threshold is 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.