Application URLs: Prevent back office hosts being overwritten in a shared database setup (closes #16741)#22160
Conversation
Add to backoffice hosts, rather than completely replacing the array
|
Hi there @matthewcare, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
|
Thanks for this @matthewcare - your fix looks like the right approach to me, though we need to consider the point you raise about old domains no longer getting cleared. I've just pushed up a couple of unit tests to verify it. I'll see about getting it reviewed tomorrow. |
Fix for #16741
Testing instructions:
Replicate the issue as detailed here:
#16741 (comment)
Without this change, you will receive the error
With this patch, you should be able to log in on each instance without issue.
Something to consider (as also mentioned in the issue comments), is that now we're just continually adding to the array with no way to clear it, we could end up with stale URIs in the database. This might be a concern if you change domain names, whereby the old domain is never cleared from the database.