Skip to content

Dependencies: Update selected dependencies to latest major versions#22060

Merged
AndyButland merged 20 commits into
v18/devfrom
v18/task/update-outdated-dependencies
Mar 17, 2026
Merged

Dependencies: Update selected dependencies to latest major versions#22060
AndyButland merged 20 commits into
v18/devfrom
v18/task/update-outdated-dependencies

Conversation

@NguyenThuyLan

@NguyenThuyLan NguyenThuyLan commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes

Description

Update outdated dependencies to their latest major versions as part of the v18 release cycle.

Changes:

  • Updated the following packages in Directory.Packages.props:

    • Serilog.Extensions.Hosting
    • Serilog.Settings.Configuration
    • Serilog.AspNetCore
    • Markdig
    • MailKit
    • Microsoft.CodeAnalysis.CSharp
  • Added Microsoft.CodeAnalysis.CSharp.Workspaces to Directory.Packages.props in tests to resolve version conflicts caused by the Microsoft.CodeAnalysis.CSharp upgrade.

Notes

How to test

  • Build the solution
  • Run all unit and integration tests

@github-actions

Copy link
Copy Markdown

Hi there @NguyenThuyLan, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@NguyenThuyLan NguyenThuyLan changed the title v18/task: Update outdated dependencies to latest major versions V18/task: Update outdated dependencies to latest major versions Mar 10, 2026
@NguyenThuyLan NguyenThuyLan marked this pull request as draft March 10, 2026 04:43
Comment thread Directory.Packages.props Outdated
@NguyenThuyLan NguyenThuyLan marked this pull request as ready for review March 16, 2026 07:49
@AndyButland AndyButland changed the title V18/task: Update outdated dependencies to latest major versions Dependencies: Update selected dependencies to latest major versions Mar 16, 2026

@AndyButland AndyButland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we've discussed, we've had some problems here in getting NUnit and the NUnit test adapter to upgrade, as somewhere within those changes there's something that triggers a problem with the integration tests running on the AzureDevOps pipeline. One group - 3 of 3 - would consistently hang and not start, until eventually timing out.

Given that we've rolled back the NUnit upgrade and will consider tackling that in a focussed PR just for that component.

The rest all looks good, and tests all pass.

@AndyButland AndyButland merged commit d2e7fc1 into v18/dev Mar 17, 2026
27 checks passed
@AndyButland AndyButland deleted the v18/task/update-outdated-dependencies branch March 17, 2026 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants