Skip to content

Umbraco back-office error previewing dummy.txt - #22

Closed
amelvin wants to merge 3 commits into
umbraco:masterfrom
amelvin:master
Closed

Umbraco back-office error previewing dummy.txt#22
amelvin wants to merge 3 commits into
umbraco:masterfrom
amelvin:master

Conversation

@amelvin

@amelvin amelvin commented Jun 21, 2013

Copy link
Copy Markdown

This is my first github pull request - so I hope it's not a disaster! From the package manager in Visual Studio 2012 I did a:

install-package umbracocms

It dropped the dummy.txt file in the scripting files, but this file errors if you try to preview it in the back-office. This is previously reported here: http://issues.umbraco.org/issue/U4-1620

unknown and others added 3 commits June 18, 2013 17:16
The default Umbraco 6 build puts a dummy.txt file in the scripting files
to stop the folder being empty, but the Umbraco back-end errors if you
click on it.  Having txt files as an allowable scriptfiletype solves
this
@nul800sebastiaan

Copy link
Copy Markdown
Member

Hey Antony, luckily you can't mess anything up! :-)
However, the fix is actually working around the problem instead of solving the root cause, which is: Text files are listed in the backoffice as viewable, even if the scriptFileTypes says they're not allowed to be. So in order to fix this, we should filter out files that we're not able to click on anyway and hide them completely.

So if you can make it work like that then we can merge your changes in.
Thanks!

@amelvin

amelvin commented Jun 24, 2013

Copy link
Copy Markdown
Author

OK, thanks for the tips - I'll have a look at fixing the root cause then.

@nul800sebastiaan

Copy link
Copy Markdown
Member

Hi Antony, in order to keep our overview clean I'm going to close this pull request for now. Still hope to see an update one!

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants