Block editors: Make block editors read-only when document is trashed (closes #21973)#21982
Merged
leekelleher merged 2 commits intomainfrom Mar 3, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ensures block editor UIs across Block List, Block Grid, Block Single, and Block RTE correctly enter a read-only rendering mode when the parent document is trashed by propagating the block manager’s read-only state into the property write-guards and hiding edit-related actions.
Changes:
- Propagate block manager read-only state into
content/settingspropertyWriteGuardrules so underlying property editors render as read-only. - Hide edit/settings/delete actions on block entry elements while in read-only mode (copy-to-clipboard remains available).
- Align
umb-ref-single-blockwith other ref blocks by adding the missing.readonly/.hrefbindings.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Umbraco.Web.UI.Client/src/packages/block/block/workspace/block-workspace.context.ts | Adds/removes denied rules on propertyWriteGuard for content/settings when block manager read-only is active. |
| src/Umbraco.Web.UI.Client/src/packages/block/block-single/components/ref-single-block/ref-single-block.element.ts | Adds .readonly and switches to property-binding .href consistent with other ref block implementations. |
| src/Umbraco.Web.UI.Client/src/packages/block/block-single/components/block-single-entry/block-single-entry.element.ts | Ensures custom views render without expose overlay in read-only and hides edit/settings actions when read-only. |
| src/Umbraco.Web.UI.Client/src/packages/block/block-rte/components/block-rte-entry/block-rte-entry.element.ts | Introduces read-only state handling and hides edit/settings/delete actions accordingly. |
| src/Umbraco.Web.UI.Client/src/packages/block/block-list/components/block-list-entry/block-list-entry.element.ts | Ensures custom views render without expose overlay in read-only and hides edit/settings actions when read-only. |
| src/Umbraco.Web.UI.Client/src/packages/block/block-grid/components/block-grid-entry/block-grid-entry.element.ts | Ensures custom views render without expose overlay in read-only and hides edit/settings actions when read-only. |
leekelleher
approved these changes
Mar 3, 2026
Member
leekelleher
left a comment
leekelleher
left a comment
There was a problem hiding this comment.
Tested out, works as described! 🚀
leekelleher
deleted the
v17/bugfix/21973-make-block-editors-readonly-when-trashed
branch
| }; | ||
|
|
||
| this.readOnlyGuard?.addRule(rule); | ||
| this.content.propertyWriteGuard.addRule({ unique, permitted: false }); |
Member
There was a problem hiding this comment.
No, we can´t just inherit the state. That would not work for Block Level Variants if the user does not have access to edit Invariant Fields but has access to edit fields of a particular Culture.
In that case the user needs to navigate via the invariant property to edit culture specific fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses: #21973
This issue showed that when a block editor is read-only - e.g. when a document is trashed, block editors - some buttons and fields were still enabled and appeared that they could be edited. Edits can't be saved, but for consistency and clarity, they shouldn't display as editable.
With this PR:
Testing