Skip to content

E2E: QA Added acceptance tests for allowing folder selection in media entity picker#21981

Merged
nhudinh0309 merged 17 commits intomainfrom
v17/QA/select-media-folder-tests
Mar 6, 2026
Merged

E2E: QA Added acceptance tests for allowing folder selection in media entity picker#21981
nhudinh0309 merged 17 commits intomainfrom
v17/QA/select-media-folder-tests

Conversation

@nhudinh0309
Copy link
Copy Markdown
Contributor

@nhudinh0309 nhudinh0309 commented Mar 3, 2026

This PR adds acceptance tests for #21895.

It includes tests to ensure that:

  • only folders are selectable and files are NOT selectable in the Rich Text Editor data type
  • only folders are selectable and files are NOT selectable for the "Start node" in the Media Picker data type
  • only media files are selectable and folders are NOT selectable in the Multi URL Picker
  • only folders are selectable and files are NOT selectable for the "Media start node" in Users
  • only folders are selectable and files are NOT selectable for the "Media start node" in User Groups

@nhudinh0309 nhudinh0309 mentioned this pull request Mar 3, 2026
Merged
4 tasks
andr317c
andr317c requested changes Mar 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@andr317c andr317c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a few comments

Comment thread tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Users/User.spec.ts
Comment thread tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/MediaPicker.spec.ts Outdated
Comment thread tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/Tiptap.spec.ts Outdated
andr317c
andr317c approved these changes Mar 6, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@andr317c andr317c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nhudinh0309 nhudinh0309 enabled auto-merge (squash) March 6, 2026 09:53
@nhudinh0309 nhudinh0309 merged commit 32270e7 into main Mar 6, 2026
27 checks passed
@nhudinh0309 nhudinh0309 deleted the v17/QA/select-media-folder-tests branch March 6, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andr317c andr317c andr317c approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nhudinh0309 @andr317c