Global Elements: Workspace UI updates: split view, variant selector, save modal, and pending changes #21897
CodeScene PR Check
Quality Gate Failed
Gates Failed
(6 files with Large Method, String Heavy Function Arguments, Complex Method, Complex Conditional, Overall Code Complexity)
Gates Passed
See analysis details in CodeScene
Reason for failure
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| element-workspace.context.ts | 2 advisory rules | 10.00 → 9.29 | Suppress |
| menu-tree-structure-workspace-context-base.ts | 1 advisory rule | 9.39 → 8.82 | Suppress |
| utils.ts | 1 advisory rule | 9.69 | Suppress |
| element-workspace-split-view-variant-selector.element.ts | 1 advisory rule | 9.69 | Suppress |
| element-published-pending-changes.manager.ts | 1 advisory rule | 9.69 | Suppress |
| element-table-collection-view.element.ts | 1 advisory rule | 10.00 → 9.69 | Suppress |
Quality Gate Profile: Clean Code Collective
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
Details
🚩 Declining Code Health (highest to lowest):
- Overall Code Complexity menu-tree-structure-workspace-context-base.ts
- Large Method element-workspace.context.ts: UmbElementWorkspaceContext.constructor
- Complex Method element-table-collection-view.element.ts: UmbElementTableCollectionViewElement.createTableItems
- Complex Method element-published-pending-changes.manager.ts: UmbElementPublishedPendingChangesManager.process
- Complex Method utils.ts: compareMandatory
- Complex Conditional element-workspace-split-view-variant-selector.element.ts: UmbElementWorkspaceSplitViewVariantSelectorElement.getVariantState
- String Heavy Function Arguments element-workspace.context.ts
✅ Improving Code Health:
- Overall Code Complexity element-publishing.workspace-context.ts
Annotations
codescene-delta-analysis / CodeScene Code Health Review (v18/dev)
❌ New issue: Large Method
UmbElementWorkspaceContext.constructor has 74 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
codescene-delta-analysis / CodeScene Code Health Review (v18/dev)
❌ New issue: String Heavy Function Arguments
In this module, 41.7% of all arguments to its 13 functions are strings. The threshold for string arguments is 39.0%. The functions in this file have a high ratio of strings as arguments. Avoid adding more.
Check warning on line 36 in src/Umbraco.Web.UI.Client/src/packages/elements/utils.ts
codescene-delta-analysis / CodeScene Code Health Review (v18/dev)
❌ New issue: Complex Method
compareMandatory has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Code Health Review (v18/dev)
❌ New issue: Complex Conditional
UmbElementWorkspaceSplitViewVariantSelectorElement.getVariantState has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
codescene-delta-analysis / CodeScene Code Health Review (v18/dev)
❌ New issue: Complex Method
UmbElementPublishedPendingChangesManager.process has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Code Health Review (v18/dev)
✅ Getting better: Overall Code Complexity
The mean cyclomatic complexity decreases from 6.77 to 6.11, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
codescene-delta-analysis / CodeScene Code Health Review (v18/dev)
❌ New issue: Overall Code Complexity
This module has a mean cyclomatic complexity of 6.00 across 7 functions. The mean complexity threshold is 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
codescene-delta-analysis / CodeScene Code Health Review (v18/dev)
❌ New issue: Complex Method
UmbElementTableCollectionViewElement.createTableItems has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.