Skip to content

Templates: Add direct Swashbuckle dependency to extension template (closes #21864) #21869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nikolajlauridsen merged 2 commits into from
Mar 10, 2026
Merged

Templates: Add direct Swashbuckle dependency to extension template (closes #21864) #21869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee9f0b7
Ensure Swashbuckle version is aligned with Umbraco in the extension t…
AndyButland Feb 23, 2026
1ae50c7
Merge branch 'main' into v17/bugfix/21864-add-swashbuckle-reference-t…
nikolajlauridsen Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@
<PackageVersion Include="Serilog.Sinks.Map" Version="2.0.0" />
<PackageVersion Include="SixLabors.ImageSharp" Version="3.1.12" />
<PackageVersion Include="SixLabors.ImageSharp.Web" Version="3.2.0" />
<!-- When updating this version, also update templates/UmbracoExtension/Umbraco.Extension.csproj -->
<PackageVersion Include="Swashbuckle.AspNetCore" Version="10.1.4" />
</ItemGroup>
<!-- Transitive pinned versions (only required because our direct dependencies have vulnerable versions of transitive dependencies) -->
Expand Down
13 changes: 13 additions & 0 deletions templates/UmbracoExtension/Umbraco.Extension.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,19 @@
<ItemGroup>
<PackageReference Include="Umbraco.Cms.Api.Common" Version="UMBRACO_VERSION_FROM_TEMPLATE" />
<PackageReference Include="Umbraco.Cms.Api.Management" Version="UMBRACO_VERSION_FROM_TEMPLATE" />

<!--
Swashbuckle is available transitively from the Umbraco packages above, but we take a direct
dependency here because extension code directly uses types from Swashbuckle (SwaggerGenOptions)
and Microsoft.OpenApi (OpenApiInfo). Without a direct reference, this project's Swashbuckle
version is determined solely by NuGet's transitive resolution, which can resolve to a different
version than the host site project (e.g. a newer patch). When that happens, the different
Microsoft.OpenApi versions (a transitive dependency of Swashbuckle) can conflict at runtime,
causing custom Swagger documents registered by the extension to fail to appear.
Most other transitive dependencies don't have this problem because extension code doesn't
use their types directly - only Swashbuckle/OpenApi types are referenced in the composer.
-->
<PackageReference Include="Swashbuckle.AspNetCore" Version="10.1.4" />
<PackageReference Include="Umbraco.Cms.Web.Common" Version="UMBRACO_VERSION_FROM_TEMPLATE" />
<PackageReference Include="Umbraco.Cms.Web.Website" Version="UMBRACO_VERSION_FROM_TEMPLATE" />
</ItemGroup>
Expand Down
Loading