Skip to content

Accessibility: Add title attributes to buttons in block list entry and property editor UI #21842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyButland merged 1 commit into from
Feb 20, 2026
Merged

Accessibility: Add title attributes to buttons in block list entry and property editor UI #21842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions ...ent/src/packages/block/block-list/components/block-list-entry/block-list-entry.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,8 @@ export class UmbBlockListEntryElement extends UmbLitElement implements UmbProper
label="edit"
look="secondary"
color=${this._contentInvalid ? 'invalid' : ''}
href=${this._workspaceEditContentPath}>
href=${this._workspaceEditContentPath}
title=${this.localize.term('general_edit')}>
<uui-icon name=${this._exposed === false && this._isReadOnly === false ? 'icon-add' : 'icon-edit'}></uui-icon>
${this._contentInvalid
? html`<uui-badge attention color="invalid" label="Invalid content">!</uui-badge>`
Expand All @@ -483,7 +484,8 @@ export class UmbBlockListEntryElement extends UmbLitElement implements UmbProper
label="Edit settings"
look="secondary"
color=${this._settingsInvalid ? 'invalid' : ''}
href=${this._workspaceEditSettingsPath}>
href=${this._workspaceEditSettingsPath}
title=${this.localize.term('general_settings')}>
<uui-icon name="icon-settings"></uui-icon>
${this._settingsInvalid
? html`<uui-badge attention color="invalid" label="Invalid settings">!</uui-badge>`
Expand All @@ -495,7 +497,7 @@ export class UmbBlockListEntryElement extends UmbLitElement implements UmbProper

#renderDeleteAction() {
if (this._isReadOnly) return nothing;
return html` <uui-button label="delete" look="secondary" @click=${() => this.#context.requestDelete()}>
return html` <uui-button label="delete" look="secondary" @click=${() => this.#context.requestDelete()} title=${this.localize.term('general_delete')}>
<uui-icon name="icon-remove"></uui-icon>
</uui-button>`;
}
Expand All @@ -505,7 +507,8 @@ export class UmbBlockListEntryElement extends UmbLitElement implements UmbProper
<uui-button
label=${this.localize.term('clipboard_labelForCopyToClipboard')}
look="secondary"
@click=${() => this.#copyToClipboard()}>
@click=${() => this.#copyToClipboard()}
title=${this.localize.term('general_copy')}>
<uui-icon name="icon-clipboard-copy"></uui-icon>
</uui-button>
`;
Expand Down
3 changes: 2 additions & 1 deletion ...ck/block-list/property-editors/block-list-editor/property-editor-ui-block-list.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,8 @@ export class UmbPropertyEditorUIBlockListElement
label=${this.localize.term('content_createFromClipboard')}
look="placeholder"
href=${this._catalogueRouteBuilder?.({ view: 'clipboard', index: -1 }) ?? ''}
?disabled=${this.readonly}>
?disabled=${this.readonly}
title=${this.localize.term('general_clipboard')}>
<uui-icon name="icon-clipboard-paste"></uui-icon>
</uui-button>
`;
Expand Down
Loading