Skip to content

Backoffice Performance: Add inflight request deduplication to item data request managers #21767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
madsrasmussen merged 4 commits into from
Feb 27, 2026
Merged

Backoffice Performance: Add inflight request deduplication to item data request managers #21767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8982ad4
add inflight request cache to all item request managers
madsrasmussen Feb 16, 2026
c5f0cae
Use inflight request cache for item data
madsrasmussen Feb 16, 2026
1226c03
Add tests for Item Data Request Manager
madsrasmussen Feb 16, 2026
f738516
Merge branch 'main' into v17/improvement/items-inflight-request-cache
madsrasmussen Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...UI.Client/src/packages/data-type/repository/item/data-type-item.server.request-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,19 @@
import { dataTypeItemCache } from './data-type-item.server.cache.js';
import type { UmbControllerHost } from '@umbraco-cms/backoffice/controller-api';
import { DataTypeService, type DataTypeItemResponseModel } from '@umbraco-cms/backoffice/external/backend-api';
import { UmbManagementApiItemDataRequestManager } from '@umbraco-cms/backoffice/management-api';
import {
UmbManagementApiItemDataRequestManager,
UmbManagementApiInFlightRequestCache,
} from '@umbraco-cms/backoffice/management-api';

export class UmbManagementApiDataTypeItemDataRequestManager extends UmbManagementApiItemDataRequestManager<DataTypeItemResponseModel> {
static #inflightRequestCache = new UmbManagementApiInFlightRequestCache<DataTypeItemResponseModel>();

constructor(host: UmbControllerHost) {
super(host, {
getItems: (ids: Array<string>) => DataTypeService.getItemDataType({ query: { id: ids } }),
dataCache: dataTypeItemCache,
inflightRequestCache: UmbManagementApiDataTypeItemDataRequestManager.#inflightRequestCache,
getUniqueMethod: (item) => item.id,
});
}
Expand Down
8 changes: 7 additions & 1 deletion ....Client/src/packages/dictionary/repository/item/dictionary-item.server.request-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,19 @@
import { dictionaryItemCache } from './dictionary-item.server.cache.js';
import type { UmbControllerHost } from '@umbraco-cms/backoffice/controller-api';
import { DictionaryService, type DictionaryItemItemResponseModel } from '@umbraco-cms/backoffice/external/backend-api';
import { UmbManagementApiItemDataRequestManager } from '@umbraco-cms/backoffice/management-api';
import {
UmbManagementApiItemDataRequestManager,
UmbManagementApiInFlightRequestCache,
} from '@umbraco-cms/backoffice/management-api';

export class UmbManagementApiDictionaryItemDataRequestManager extends UmbManagementApiItemDataRequestManager<DictionaryItemItemResponseModel> {
static #inflightRequestCache = new UmbManagementApiInFlightRequestCache<DictionaryItemItemResponseModel>();

constructor(host: UmbControllerHost) {
super(host, {
getItems: (ids: Array<string>) => DictionaryService.getItemDictionary({ query: { id: ids } }),
dataCache: dictionaryItemCache,
inflightRequestCache: UmbManagementApiDictionaryItemDataRequestManager.#inflightRequestCache,
getUniqueMethod: (item) => item.id,
});
}
Expand Down
8 changes: 7 additions & 1 deletion ...nts/document-blueprints/repository/item/document-blueprint-item.server.request-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,19 @@ import {
DocumentBlueprintService,
type DocumentBlueprintItemResponseModel,
} from '@umbraco-cms/backoffice/external/backend-api';
import { UmbManagementApiItemDataRequestManager } from '@umbraco-cms/backoffice/management-api';
import {
UmbManagementApiItemDataRequestManager,
UmbManagementApiInFlightRequestCache,
} from '@umbraco-cms/backoffice/management-api';

export class UmbManagementApiDocumentBlueprintItemDataRequestManager extends UmbManagementApiItemDataRequestManager<DocumentBlueprintItemResponseModel> {
static #inflightRequestCache = new UmbManagementApiInFlightRequestCache<DocumentBlueprintItemResponseModel>();

constructor(host: UmbControllerHost) {
super(host, {
getItems: (ids: Array<string>) => DocumentBlueprintService.getItemDocumentBlueprint({ query: { id: ids } }),
dataCache: documentBlueprintItemCache,
inflightRequestCache: UmbManagementApiDocumentBlueprintItemDataRequestManager.#inflightRequestCache,
getUniqueMethod: (item) => item.id,
});
}
Expand Down
8 changes: 7 additions & 1 deletion ...ges/documents/document-types/repository/item/document-type-item.server.request-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,19 @@
import { documentTypeItemCache } from './document-type-item.server.cache.js';
import type { UmbControllerHost } from '@umbraco-cms/backoffice/controller-api';
import { DocumentTypeService, type DocumentTypeItemResponseModel } from '@umbraco-cms/backoffice/external/backend-api';
import { UmbManagementApiItemDataRequestManager } from '@umbraco-cms/backoffice/management-api';
import {
UmbManagementApiItemDataRequestManager,
UmbManagementApiInFlightRequestCache,
} from '@umbraco-cms/backoffice/management-api';

export class UmbManagementApiDocumentTypeItemDataRequestManager extends UmbManagementApiItemDataRequestManager<DocumentTypeItemResponseModel> {
static #inflightRequestCache = new UmbManagementApiInFlightRequestCache<DocumentTypeItemResponseModel>();

constructor(host: UmbControllerHost) {
super(host, {
getItems: (ids: Array<string>) => DocumentTypeService.getItemDocumentType({ query: { id: ids } }),
dataCache: documentTypeItemCache,
inflightRequestCache: UmbManagementApiDocumentTypeItemDataRequestManager.#inflightRequestCache,
getUniqueMethod: (item) => item.id,
});
}
Expand Down
8 changes: 7 additions & 1 deletion .../src/packages/documents/documents/item/repository/document-item.server.request-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,19 @@
import { documentItemCache } from './document-item.server.cache.js';
import type { UmbControllerHost } from '@umbraco-cms/backoffice/controller-api';
import { DocumentService, type DocumentItemResponseModel } from '@umbraco-cms/backoffice/external/backend-api';
import { UmbManagementApiItemDataRequestManager } from '@umbraco-cms/backoffice/management-api';
import {
UmbManagementApiItemDataRequestManager,
UmbManagementApiInFlightRequestCache,
} from '@umbraco-cms/backoffice/management-api';

export class UmbManagementApiDocumentItemDataRequestManager extends UmbManagementApiItemDataRequestManager<DocumentItemResponseModel> {
static #inflightRequestCache = new UmbManagementApiInFlightRequestCache<DocumentItemResponseModel>();

constructor(host: UmbControllerHost) {
super(host, {
getItems: (ids: Array<string>) => DocumentService.getItemDocument({ query: { id: ids } }),
dataCache: documentItemCache,
inflightRequestCache: UmbManagementApiDocumentItemDataRequestManager.#inflightRequestCache,
getUniqueMethod: (item) => item.id,
});
}
Expand Down
8 changes: 7 additions & 1 deletion ...b.UI.Client/src/packages/language/repository/item/language-item.server.request-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,19 @@
import { languageItemCache } from './language-item.server.cache.js';
import type { UmbControllerHost } from '@umbraco-cms/backoffice/controller-api';
import { LanguageService, type LanguageItemResponseModel } from '@umbraco-cms/backoffice/external/backend-api';
import { UmbManagementApiItemDataRequestManager } from '@umbraco-cms/backoffice/management-api';
import {
UmbManagementApiItemDataRequestManager,
UmbManagementApiInFlightRequestCache,
} from '@umbraco-cms/backoffice/management-api';

export class UmbManagementApiLanguageItemDataRequestManager extends UmbManagementApiItemDataRequestManager<LanguageItemResponseModel> {
static #inflightRequestCache = new UmbManagementApiInFlightRequestCache<LanguageItemResponseModel>();

constructor(host: UmbControllerHost) {
super(host, {
getItems: (isoCodes: Array<string>) => LanguageService.getItemLanguage({ query: { isoCode: isoCodes } }),
dataCache: languageItemCache,
inflightRequestCache: UmbManagementApiLanguageItemDataRequestManager.#inflightRequestCache,
getUniqueMethod: (item) => item.isoCode,
});
}
Expand Down
Loading
Loading