Tiptap RTE: Resolves inline blocks being set as dirty (closes #17749)#21546
Merged
nielslyngsoe merged 4 commits intomainfrom Jan 28, 2026
Merged
Tiptap RTE: Resolves inline blocks being set as dirty (closes #17749)#21546nielslyngsoe merged 4 commits intomainfrom
nielslyngsoe merged 4 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR resolves issue #17749 where adding inline blocks to the Tiptap Rich Text Editor incorrectly marks content as dirty, triggering unnecessary "Unsaved Changes" dialogs.
Changes:
- Moved
displayInlinedetermination from runtime layout modification to block type configuration lookup - Removed automatic layout property setting that was causing dirty state
- Deprecated layout-based
displayInlineproperty in favor of block type configuration - Simplified block observation by removing unnecessary
distinctUntilChangedoperator (deduplication is already handled byUmbDeepState)
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
block.tiptap-api.ts |
Added block types observation and changed inline block detection to use block type config instead of layout, eliminating layout mutations that triggered dirty state |
types.ts |
Deprecated displayInline on UmbBlockRteLayoutModel in favor of block type configuration |
block-rte-manager.context.ts |
Removed code that automatically set displayInline on layout during block creation, preventing unwanted modifications |
block-rte-entry.context.ts |
Removed displayInlineCorrection logic that synced layout with config, as it's no longer needed; kept deprecated observable for backwards compatibility |
src/Umbraco.Web.UI.Client/src/packages/tiptap/extensions/block/block.tiptap-api.ts
Outdated
Show resolved
Hide resolved
…/block.tiptap-api.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
src/Umbraco.Web.UI.Client/src/packages/tiptap/extensions/block/block.tiptap-api.ts
Show resolved
Hide resolved
nielslyngsoe
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #17749.
Whilst PR #17692 did fix issue #17749, it was re-opened with a subsequent issue, in that if a Block (configured with "Display Inline") was added to the RTE, it would set the contents as dirty, prompting the "Unsaved Changes" modal.
This PR resolves this by moving the
displayInlinelogic from the Block Layout to getting the configuration from the Block Type instead.