Back-office auth: Calculate token cookie names at request time (Closes #21050)#21056
Merged
Migaroez merged 2 commits intorelease/17.0from Dec 5, 2025
Merged
Back-office auth: Calculate token cookie names at request time (Closes #21050)#21056Migaroez merged 2 commits intorelease/17.0from
Migaroez merged 2 commits intorelease/17.0from
Conversation
The __Host- cookie prefix enforces secure cookies at browser level, which caused cookies to be rejected when running over HTTP in local development environments even when UseHttps was set to false. Cookie names are now calculated per-request based on both the UseHttps setting and whether the current request is over HTTPS, matching the logic used for the Secure cookie option.
Migaroez
approved these changes
Dec 4, 2025
src/Umbraco.Cms.Api.Common/DependencyInjection/HideBackOfficeTokensHandler.cs
Outdated
Show resolved
Hide resolved
src/Umbraco.Cms.Api.Common/DependencyInjection/HideBackOfficeTokensHandler.cs
Show resolved
Hide resolved
src/Umbraco.Cms.Api.Common/DependencyInjection/HideBackOfficeTokensHandler.cs
Show resolved
Hide resolved
…okensHandler.cs Co-authored-by: Sven Geusens <sge@umbraco.dk>
This was referenced Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
If there's an existing issue for this PR then this fixes #21050
Description
The
__Host-cookie prefix enforces secure cookies at browser level, which causes cookies to be rejected when running over HTTP in local development environments even whenUseHttpsis set to false.With this PR, cookie names are now calculated per-request based on both the
UseHttpssetting and whether the current request is over HTTPS, matching the logic used for the Secure cookie option.Testing this PR
UseHttpsis set totrue, it should be possible to log into the backoffice over HTTPS.UseHttpsis set tofalse, it should be possible to log into the backoffice over both HTTPS and HTTP.Also verify that the resulting cookie name prefixes (for
umbAccessTokenandumbRefreshToken) follow these rules:UseHttpstrue__Host-false__Host-false