Fixes: U4-3450 Prevalue alias is not added to package XML#210
Fixes: U4-3450 Prevalue alias is not added to package XML#210leekelleher wants to merge 1 commit intoumbraco:6.2.0from
Conversation
|
@nul800sebastiaan Bump on an old PR... is this still relevant, or should we close it off? |
|
I've added the task to be considered for next core sprint - The packaging code is still old so this still might be slightly relevant however all of this code will be removed in v8 so the code will need to be moved into the correct place. We can review this when we get to the task but in the meantime if you already know the answer or other details please let us know :) |
|
Thanks @Shazwazza. At the time, this PR was the bookend for issue U4-2833 (PR #205), but that got closed off. I'm not sure how relevant this feature/patch is now. I only experienced it with my Google Maps data-type package for v6. If the packaging engine is going to be rebuilt/refactored for v8+, then this PR would become obsolete. (I've only commented on it now, as I'm doing housekeeping on my old GitHub issues/PRs - I'm cool to keep it open for the time being) |
|
This PR has been closed because it was targetting a branch such as |
Extends the
DataTypeDefinition.ToXmlmethod to include a prevalue's alias name for the package XML manifest.Fixes U4-3450