Skip to content

Fixes: U4-3450 Prevalue alias is not added to package XML#210

Closed
leekelleher wants to merge 1 commit intoumbraco:6.2.0from
leekelleher:U4-3450
Closed

Fixes: U4-3450 Prevalue alias is not added to package XML#210
leekelleher wants to merge 1 commit intoumbraco:6.2.0from
leekelleher:U4-3450

Conversation

@leekelleher
Copy link
Member

@leekelleher leekelleher commented Nov 7, 2013

Extends the DataTypeDefinition .ToXml method to include a prevalue's alias name for the package XML manifest.

Fixes U4-3450

@leekelleher
Copy link
Member Author

@nul800sebastiaan Bump on an old PR... is this still relevant, or should we close it off?

@Shazwazza
Copy link
Contributor

I've added the task to be considered for next core sprint - The packaging code is still old so this still might be slightly relevant however all of this code will be removed in v8 so the code will need to be moved into the correct place. We can review this when we get to the task but in the meantime if you already know the answer or other details please let us know :)

@leekelleher
Copy link
Member Author

Thanks @Shazwazza. At the time, this PR was the bookend for issue U4-2833 (PR #205), but that got closed off.

I'm not sure how relevant this feature/patch is now. I only experienced it with my Google Maps data-type package for v6. If the packaging engine is going to be rebuilt/refactored for v8+, then this PR would become obsolete.

(I've only commented on it now, as I'm doing housekeeping on my old GitHub issues/PRs - I'm cool to keep it open for the time being)

@zpqrtbnk zpqrtbnk closed this May 3, 2016
@zpqrtbnk
Copy link
Contributor

zpqrtbnk commented May 3, 2016

This PR has been closed because it was targetting a branch such as 7.x.x, and these branches are closed when the version is released, and replaced with a simple release-7.x.x tag. If the PR is still relevant, we invite you to re-submit the PR, targetting the current version 7 development branch, ie dev-v7. Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments