Delivery API: Only add default strategy if delivery API is not registered.#20982
Merged
kjac merged 3 commits intorelease/17.0from Nov 28, 2025
Merged
Delivery API: Only add default strategy if delivery API is not registered.#20982kjac merged 3 commits intorelease/17.0from
kjac merged 3 commits intorelease/17.0from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where webhooks and the Delivery API conflicted when registering output expansion strategy services, depending on their registration order. The fix ensures that webhook registrations only occur if the Delivery API hasn't already registered them, regardless of which is registered first.
Key Changes
- Changed from
AddScoped/AddSingletontoTryAddScoped/TryAddSingletonfor output expansion strategy registrations - Updated the using statement to include
Microsoft.Extensions.DependencyInjection.Extensionsto access theTryAdd*methods - Updated comments to clarify the registration behavior
src/Umbraco.Cms.Api.Management/DependencyInjection/WebhooksBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
…lderExtensions.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
AndyButland
pushed a commit
that referenced
this pull request
Dec 3, 2025
…ered. (#20982) * Only add if not already present * Update src/Umbraco.Cms.Api.Management/DependencyInjection/WebhooksBuilderExtensions.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Kenn Jacobsen <kja@umbraco.dk>
AndyButland
pushed a commit
that referenced
this pull request
Dec 3, 2025
…ered. (#20982) * Only add if not already present * Update src/Umbraco.Cms.Api.Management/DependencyInjection/WebhooksBuilderExtensions.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Kenn Jacobsen <kja@umbraco.dk>
This was referenced Dec 8, 2025
Closed
Bump Umbraco.Cms.Persistence.EFCore from 17.0.0 to 17.0.1
karl-sjogren/umbraco-extend-everything#134
Closed
Merged
This was referenced Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20976
Notes
How to test
.AddDeliveryApi(), make sure you both test when its registered before AND after.AddComposers()https://localhost:44339/umbraco/delivery/api/v2/content/item/0a75bce4-4ea2-40ec-a38e-0716adc07726https://localhost:44339/umbraco/delivery/api/v2/content/item/0a75bce4-4ea2-40ec-a38e-0716adc07726?fields=properties[title]https://localhost:44339/umbraco/delivery/api/v2/content/item/0a75bce4-4ea2-40ec-a38e-0716adc07726?expand=properties[picker[properties[$all]]]