Rendering: Don't cache RTE value conversion (closes #20867)#20880
Merged
AndyButland merged 1 commit intorelease/17.0from Nov 18, 2025
Merged
Rendering: Don't cache RTE value conversion (closes #20867)#20880AndyButland merged 1 commit intorelease/17.0from
AndyButland merged 1 commit intorelease/17.0from
Conversation
AndyButland
approved these changes
Nov 18, 2025
Contributor
AndyButland
left a comment
There was a problem hiding this comment.
Have verified that the original issue reported is resolved by this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
If there's an existing issue for this PR then this fixes #20867
Description
With the removal of snapshot cache, the
Snapshotproperty cache level is treated as if it was anElementlevel cache (see comment here).This has worked seemingly fine, because `Element? level caching was effectively not happening. But with the fix in #20681, the linked issue popped up quite immediately.
I have been back and forth on this one a few times, and the only immediate (stable) solution is to set the RTE value conversion cache level to
Noneinstead ofSnapshot. I have also added a task to our internal backlog to investigate this further.At first glance, the
Nonecache level looks like quite the performance degradation. In effect, though, it really isn't:Snapshotin V14 and below meant a re-rendering for each request; the cache lasted for the duration of the snapshot, which was effectively per request.Snapshotin V15+ should have been behaving likeElement, but due to the above-mentioned error, allElementlevel caching was effectively discarded.Testing this PR
See the linked issue for details.
I have verified that this works both for RTEs and Block Editors (including nested blocks).