Skip to content

Backoffice Login: Redact back-office PKCE codes from the server#20847

Merged
kjac merged 2 commits into
release/17.0from
v17/feature/redact-pkce-code
Nov 17, 2025
Merged

Backoffice Login: Redact back-office PKCE codes from the server#20847
kjac merged 2 commits into
release/17.0from
v17/feature/redact-pkce-code

Update src/Umbraco.Cms.Api.Common/DependencyInjection/HideBackOfficeT…

b6549ad
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Code Health Review (release/17.0) failed Nov 17, 2025 in 34s

CodeScene PR Check

Quality Gate Failed

Gates Failed
Enforce advisory code health rules (1 file with Large Method)

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Reason for failure
Enforce advisory code health rules Violations Code Health Impact
UmbracoBuilderAuthExtensions.cs 1 advisory rule 9.54 → 9.51 Suppress

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method UmbracoBuilderAuthExtensions.cs: ConfigureOpenIddict

Annotations

Check warning on line 129 in src/Umbraco.Cms.Api.Common/DependencyInjection/UmbracoBuilderAuthExtensions.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Code Health Review (release/17.0)

❌ Getting worse: Large Method

ConfigureOpenIddict increases from 82 to 88 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.