Adding the requested changes via my own fork#20664
Merged
iOvergaard merged 1 commit intoumbraco:v16/feature/add-show-password-fieldfrom Oct 27, 2025
Merged
Conversation
…hat are imported instead of having the raw svg in the code
iOvergaard
approved these changes
Oct 27, 2025
iOvergaard
merged commit 8b544f8
into
umbraco:v16/feature/add-show-password-field
5 checks passed
iOvergaard
added a commit
that referenced
this pull request
Oct 30, 2025
* Implimented an inline toggle button to show/hide your password, also changed the css to accommodate these changes * Cleaned the css Added the svg's to their own const for easy reuse Added localization for the arialabel on the button Seperated the createFormLayoutItem so there is a seperate for the password input Moved all the conditional logic in the onclick event to fit inside one if/else statement * Removed old logic that added a 100ms timeout that would sometimes be enough for localization to load, and replaced it with a function. The function will try and resolve the promise by checking if the localize.terms methods returns a changed value, if not then it retries every 50ms or untill it hits a max retry of 40/2 seconds. * Re adding the hide for -ms-reveal to support Microsoft Edge browsers * Removed a console.log * Alligned the button behavior so it fits better with what we have in the uui libary. Now the button is always visible instead of appearing on hover or when in focus * Update src/Umbraco.Web.UI.Login/src/auth.element.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/Umbraco.Web.UI.Login/src/auth.element.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @iOvergaard * Apply suggestion from @iOvergaard * Adding the requested changes via my own fork (#20664) Changed the logic for waitForLocallization Added the svg's as files that are imported instead of having the raw svg in the code --------- Co-authored-by: Jacob Overgaard <752371+iOvergaard@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the requested changes to the PR via my own fork.