Skip to content

Content picker: Implement a specific sorting method for statuses (closes #20646) #20609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nielslyngsoe merged 1 commit into from
Oct 22, 2025
Merged

Content picker: Implement a specific sorting method for statuses (closes #20646) #20609

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/Umbraco.Web.UI.Client/src/packages/core/repository/repository-items.manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ export class UmbRepositoryItemsManager<ItemType extends { unique: string }> exte
) {
const items = this.#items.getValue();
this.#items.setValue(this.#sortByUniques(items));
this.#statuses.setValue(this.#sortByUniques(statuses));
this.#statuses.setValue(this.#sortStatusByUniques(statuses));
} else {
// We need to load new items, so ...
this.#requestItems();
Expand Down Expand Up @@ -260,7 +260,7 @@ export class UmbRepositoryItemsManager<ItemType extends { unique: string }> exte
}
}

#sortByUniques<T extends Pick<ItemType, 'unique'>>(data?: Array<T>): Array<T> {
#sortByUniques(data?: Array<ItemType>): Array<ItemType> {
if (!data) return [];
const uniques = this.getUniques();
return [...data].sort((a, b) => {
Expand All @@ -270,6 +270,17 @@ export class UmbRepositoryItemsManager<ItemType extends { unique: string }> exte
});
}

/** Just needed for the deprecation implementation to work, do not bring this into 17.0 [NL] */
#sortStatusByUniques(data?: Array<UmbRepositoryItemsStatus>): Array<UmbRepositoryItemsStatus> {
if (!data) return [];
const uniques = this.getUniques();
return [...data].sort((a, b) => {
const aIndex = uniques.indexOf(a.unique ?? '');
const bIndex = uniques.indexOf(b.unique ?? '');
return aIndex - bIndex;
});
}

#onEntityUpdatedEvent = (event: UmbEntityUpdatedEvent) => {
const eventUnique = event.getUnique();

Expand Down
Loading