-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Preview: Allows changing the preview environment inside the preview app, and other UX changes that enhance the experience #20598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
af4e46b
Preview Device: refactored config
leekelleher 9cdd0ca
Preview element CSS refinement
leekelleher 54bda16
Preview element: load in private extensions
leekelleher 073bae5
Added "Preview Environments" preview-app
leekelleher eaa1cf6
Aligned preview-app design
leekelleher ccfa03d
Created "Preview" package
leekelleher 32470bc
Relocated "Preview Apps" and Context to the new package
leekelleher 12a29e1
Deprecated `UmbDocumentPreviewRepository` (for v19)
leekelleher fae914d
Removed Preview Sessions event listeners
leekelleher d70817a
Changed localization from "End" to "Exit"
leekelleher 87f61ae
Merge remote-tracking branch 'origin/v17/dev' into v17/feature/previe…
iOvergaard 328b008
chore: consumes context only when needed
iOvergaard f2ef40d
feat: uses the UmbPreviewRepository instead
iOvergaard b0aebde
feat: adds localization to errors and ensures the function does not r…
iOvergaard a2a5e1a
feat: prevents creating a new repository for every click
iOvergaard ee49a99
feat: prevents potential memory leak by adding a signal to the events…
iOvergaard 2410163
feat: adds a custom interface to prevent typescript errors
iOvergaard 95e1602
feat: ensures new string states are checked properly
iOvergaard e13319a
docs: adds comment to avoid confusion
iOvergaard 0665d14
feat: sets up scaling once per iframe load rather than on each update
iOvergaard a5f877a
fix: ensures that you can go back to the default segment again
iOvergaard 19f5f01
feat: closes popovers when clicking on the iframe (losing blur) and i…
iOvergaard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export * from './preview.element.js'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
src/Umbraco.Web.UI.Client/src/packages/preview/context/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| export * from './preview.context.js'; | ||
| export * from './preview.context-token.js'; |
4 changes: 4 additions & 0 deletions
4
src/Umbraco.Web.UI.Client/src/packages/preview/context/preview.context-token.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| import type { UmbPreviewContext } from './preview.context.js'; | ||
| import { UmbContextToken } from '@umbraco-cms/backoffice/context-api'; | ||
|
|
||
| export const UMB_PREVIEW_CONTEXT = new UmbContextToken<UmbPreviewContext>('UmbPreviewContext'); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.